Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756326AbdIHQWQ (ORCPT ); Fri, 8 Sep 2017 12:22:16 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:35172 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756218AbdIHQWO (ORCPT ); Fri, 8 Sep 2017 12:22:14 -0400 X-Google-Smtp-Source: ADKCNb7FNFO3El26zdjqBGOTprP1J+kHChFOii8oHHQkRkFAIm3bGweQI+siE15p4dZRZQ00TcBCHHqFGzaX8i0fitY= MIME-Version: 1.0 In-Reply-To: <0184EA26B2509940AA629AE1405DD7F2015F5F11@DGGEMA503-MBX.china.huawei.com> References: <0184EA26B2509940AA629AE1405DD7F2015F5F11@DGGEMA503-MBX.china.huawei.com> From: Peter Maydell Date: Fri, 8 Sep 2017 17:21:52 +0100 Message-ID: Subject: Re: [PATCH v11 5/6] target-arm: kvm64: handle SIGBUS signal for synchronous External Abort To: gengdongjiu Cc: "Michael S. Tsirkin" , Igor Mammedov , Zhaoshenglong , Paolo Bonzini , QEMU Developers , qemu-arm , kvm-devel , "edk2-devel@lists.01.org" , Christoffer Dall , Marc Zyngier , Will Deacon , James Morse , Tyler Baicar , Ard Biesheuvel , Ingo Molnar , "bp@suse.de" , Shiju Jose , "zjzhang@codeaurora.org" , arm-mail-list , "kvmarm@lists.cs.columbia.edu" , lkml - Kernel Mailing List , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , John Garry , Jonathan Cameron , Shameerali Kolothum Thodi , huangdaode , "Wangzhou (B)" , Huangshaoyu , Wuquanming , Linuxarm , "Zhengqiang (turing)" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1748 Lines: 54 On 8 September 2017 at 17:17, gengdongjiu wrote: >> >> This code has all just been copied-and-pasted from target/i386/kvm.c. >> Please instead abstract it out properly into a cpu-independent source file. > > > Yes, it copied from x86. > Do you mean abstracting this code to a common folder so that i386 and arm platform share it? I mean it should go into a common source file (perhaps accel/kvm/kvm-all.c). >> What is this ??? You should never need to look up things in the cpreg arrays by fieldoffset. > > > I used it to set the esr_el1's and far_el1's value, for example: > > /* set ESR_EL1 */ > ret = kvm_arm_cpreg_value(cpu, offsetof(CPUARMState, cp15.esr_el[1])); > > /* set FAR_EL1 */ > ret = kvm_arm_cpreg_value(cpu, offsetof(CPUARMState, cp15.far_el[1])); Yes, I saw that, but I have no idea why you think that's the right way to set register values. No other code in QEMU does this. > So use the added API kvm_arm_cpreg_value() to set their value. > If not used it, do you better method to set their value? I suggest: >> The code for handling debug exits (software step, watchpoint, >> etc) is probably a good place to look for how to deal with register state. >> Any new globally-visible function prototype in a header should >> have a doc-comment formatted documentation comment, please. > > > Ok, thanks for this reminder. Do you mean I need to add comments > for this globally-visible function, such as below: > > /* > * xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > */ > void kvm_hwpoison_page_add(ram_addr_t ram_addr); It should be in the doc-comment format, which begins "/**" and has some stylization of how you list parameters and so on. Lots of examples in the existing headers. thanks -- PMM