Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbdIHRPA (ORCPT ); Fri, 8 Sep 2017 13:15:00 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:44994 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbdIHRO7 (ORCPT ); Fri, 8 Sep 2017 13:14:59 -0400 From: Eugeniy Paltsev To: "Eugeniy.Paltsev@synopsys.com" , "Vineet Gupta" , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" Subject: Re: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Thread-Topic: [PATCH] ARC: AXS10x: Add temporary quirk to reset ethernet IP Thread-Index: AQHTJzztmnKoYVVrREiyc8eK+7/vE6KoJAmAgAL36wA= Date: Fri, 8 Sep 2017 17:14:52 +0000 Message-ID: <1504890890.30546.15.camel@synopsys.com> References: <20170906182108.16765-1-Eugeniy.Paltsev@synopsys.com> <948bc9d9-7cef-4574-2ec9-0e9b0e5e0772@synopsys.com> In-Reply-To: <948bc9d9-7cef-4574-2ec9-0e9b0e5e0772@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <57B8E25859C1B0429FEB12F4936318AF@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v88HF49D026568 Content-Length: 1593 Lines: 53 On Wed, 2017-09-06 at 12:54 -0700, Vineet Gupta wrote: > On 09/06/2017 11:21 AM, Eugeniy Paltsev wrote: > > DW ethernet controller on AXS10x hangs sometimes after SW reset, so > > add temporary quirk to reset DW ethernet controller IP core. > > This quirk can be removed after axs10x reset driver > > (see http://patchwork.ozlabs.org/patch/800273/) > > or simple reset driver > > (see https://patchwork.kernel.org/patch/9903375/) > > will be available in upstream. > > > > Signed-off-by: Eugeniy Paltsev > > Added to for-next ! > > Thx, Hi Vineet, Please specify if you have plans to add this patch to 4.14? I'm asking because we mostly need this quirk in 4.14 - I hope generic simple reset driver will be available in 4.15. Thanks. > > > --- > >   arch/arc/plat-axs10x/axs10x.c | 7 +++++++ > >   1 file changed, 7 insertions(+) > > > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > > index f1ac679..cf14ebc 100644 > > --- a/arch/arc/plat-axs10x/axs10x.c > > +++ b/arch/arc/plat-axs10x/axs10x.c > > @@ -111,6 +111,13 @@ static void __init axs10x_early_init(void) > >    > >    axs10x_enable_gpio_intc_wire(); > >    > > + /* > > +  * Reset ethernet IP core. > > +  * TODO: get rid of this quirk after axs10x reset driver (or simple > > +  * reset driver) will be available in upstream. > > +  */ > > + iowrite32((1 << 5), (void __iomem *) CREG_MB_SW_RESET); > > + > >    scnprintf(mb, 32, "MainBoard v%d", mb_rev); > >    axs10x_print_board_ver(CREG_MB_VER, mb); > >   } > > > > --  Eugeniy Paltsev