Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756585AbdIHRaf (ORCPT ); Fri, 8 Sep 2017 13:30:35 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34260 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbdIHRad (ORCPT ); Fri, 8 Sep 2017 13:30:33 -0400 X-Google-Smtp-Source: AOwi7QBS93MQPTrXqVGDuP4uSSO80JRWkIDMI1dNMKkKwCuF3VA7UmLSvS+O1eKvnX/LptyspWGdsJ3N2kpEyPjh5aY= MIME-Version: 1.0 In-Reply-To: <20170908094559.GC2914@kroah.com> References: <20170908012214.19047-1-Badhri@google.com> <20170908094559.GC2914@kroah.com> From: Badhri Jagan Sridharan Date: Fri, 8 Sep 2017 10:29:52 -0700 Message-ID: Subject: Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps To: Greg Kroah-Hartman Cc: Guenter Roeck , devel@driverdev.osuosl.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v88HUfRD026928 Content-Length: 1923 Lines: 45 On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman wrote: > On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: >> The source and sink caps should follow the following rules. >> This patch validates whether the src_caps/snk_caps adheres >> to it. >> >> 6.4.1 Capabilities Message >> A Capabilities message (Source Capabilities message or Sink >> Capabilities message) shall have at least one Power >> Data Object for vSafe5V. The Capabilities message shall also >> contain the sending Port’s information followed by up to >> 6 additional Power Data Objects. Power Data Objects in a >> Capabilities message shall be sent in the following order: >> >> 1. The vSafe5V Fixed Supply Object shall always be the first object. >> 2. The remaining Fixed Supply Objects, if present, shall be sent >> in voltage order; lowest to highest. >> 3. The Battery Supply Objects, if present shall be sent in Minimum >> Voltage order; lowest to highest. >> 4. The Variable Supply (non-battery) Objects, if present, shall be >> sent in Minimum Voltage order; lowest to highest. >> >> Errors in source/sink_caps of the local port will prevent >> the port registration. Whereas, errors in source caps of partner >> device would only log them. >> >> Signed-off-by: Badhri Jagan Sridharan >> --- >> drivers/staging/typec/pd.h | 2 + >> drivers/staging/typec/tcpm.c | 107 +++++++++++++++++++++++++++++++++++++++---- >> drivers/staging/typec/tcpm.h | 16 +++---- >> 3 files changed, 108 insertions(+), 17 deletions(-) > > Before you add more stuff to this driver, what is needed to get it out > of staging? That would be more useful to do now, right? Actually not adding more features here. There was a bug where the phone wasnt charging at the highest possible power output, came up with the these patches while debugging that issue. > > thanks, > > greg k-h