Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756700AbdIHRn1 (ORCPT ); Fri, 8 Sep 2017 13:43:27 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:42936 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756303AbdIHRn0 (ORCPT ); Fri, 8 Sep 2017 13:43:26 -0400 X-IronPort-AV: E=Sophos;i="5.42,362,1500933600"; d="scan'208";a="236829113" Date: Fri, 8 Sep 2017 19:42:55 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Harsha Sharma cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] staging: typec: tcpm: Comparison to NULL pointer In-Reply-To: <1504892391-5607-1-git-send-email-harshasharmaiitr@gmail.com> Message-ID: References: <1504892391-5607-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 43 Maybe "Rewrite comparison to NULL pointer" in the subject to include what was done, not just code was touched. On Fri, 8 Sep 2017, Harsha Sharma wrote: > Makes code more concise and readable Makes -> Make. Commit logs should be written in the imperative, like you are telling someone what to do. julia > Signed-off-by: Harsha Sharma > --- > Change in v2: > -Change in subject > -Change in log message > drivers/staging/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c > index 630fe75..9f4a5a5 100644 > --- a/drivers/staging/typec/tcpm.c > +++ b/drivers/staging/typec/tcpm.c > @@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload, > } > port->partner_altmode[pmdata->altmodes] = > typec_partner_register_altmode(port->partner, paltmode); > - if (port->partner_altmode[pmdata->altmodes] == NULL) { > + if (!port->partner_altmode[pmdata->altmodes]) { > tcpm_log(port, > "Failed to register alternate modes for SVID 0x%04x", > paltmode->svid); > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504892391-5607-1-git-send-email-harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >