Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbdIHRrs (ORCPT ); Fri, 8 Sep 2017 13:47:48 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:37497 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932381AbdIHRrq (ORCPT ); Fri, 8 Sep 2017 13:47:46 -0400 Date: Fri, 8 Sep 2017 19:47:18 +0200 From: Pablo Neira Ayuso To: Arvind Yadav Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, davem@davemloft.net Subject: Re: [netfilter-core] [PATCH] netfilter: nat: constify rhashtable_params Message-ID: <20170908174718.GA1727@salvia> References: <20170908114630.GA13575@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170908114630.GA13575@salvia> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 474 Lines: 11 On Fri, Sep 08, 2017 at 01:46:30PM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote: > > rhashtable_params are not supposed to change at runtime. All > > Functions rhashtable_* working with const rhashtable_params > > provided by . So mark the non-const structs > > as const. > > Applied to nf, thanks. Actually, I tossed this. NAT rhashtable has been reverted, so no need for this constification anymore.