Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756686AbdIHR6p (ORCPT ); Fri, 8 Sep 2017 13:58:45 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38127 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756302AbdIHR6o (ORCPT ); Fri, 8 Sep 2017 13:58:44 -0400 X-Google-Smtp-Source: ADKCNb7F/DW3HsKScY+WxuBKvy/fRVzjRVt2OfOUWQloHcAwSV543fInK7KpahrSutRhtq+4sQYMnQ== Subject: Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Jiri Olsa , Namhyung Kim References: <1504754336-9824-1-git-send-email-treeze.taeung@gmail.com> <20170908143628.GB10112@kernel.org> From: Taeung Song Message-ID: Date: Sat, 9 Sep 2017 02:58:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908143628.GB10112@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1939 Lines: 68 Thank you !! :) - Taeung On 09/08/2017 11:36 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu: >> When there isn't a config file (e.g. ~/.perfconfig) >> or it has nothing, the config set wasn't created. >> If the config set not exists, a config file can't be autogenerated. >> >> So allow creating a empty config set in the above case, >> then we can support the config file autogeneration. > > Applied, and rephased a bit the cset log message. > > - Arnaldo > >> Before: >> >> $ rm -f ~/.perfconfig >> $ perf config --user report.children=false >> >> $ cat ~/.perfconfig >> cat: /root/.perfconfig: No such file or directory >> >> But I think it should work even if there isn't a config file. >> >> After: >> >> $ rm -f ~/.perfconfig >> $ perf config --user report.children=false >> >> $ cat ~/.perfconfig >> # this file is auto-generated. >> [report] >> children = false >> >> NOTE: >> As a result, if perf_config_set__init() is failed, >> it seems that the config set isn't freed. But it isn't a problem. >> Because the config set will be freed by perf_config_set__delete() >> at the end of cmd_config(). >> >> Cc: Jiri Olsa >> Cc: Namhyung Kim >> Signed-off-by: Taeung Song >> --- >> tools/perf/util/config.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c >> index bc75596..d2b6983 100644 >> --- a/tools/perf/util/config.c >> +++ b/tools/perf/util/config.c >> @@ -700,10 +700,7 @@ struct perf_config_set *perf_config_set__new(void) >> >> if (set) { >> INIT_LIST_HEAD(&set->sections); >> - if (perf_config_set__init(set) < 0) { >> - perf_config_set__delete(set); >> - set = NULL; >> - } >> + perf_config_set__init(set); >> } >> >> return set; >> -- >> 2.7.4