Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757109AbdIHUQx (ORCPT ); Fri, 8 Sep 2017 16:16:53 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:46951 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757063AbdIHUQu (ORCPT ); Fri, 8 Sep 2017 16:16:50 -0400 X-Google-Smtp-Source: AOwi7QAFAH1MjB3STkekdn3en3/AXxHkNEM9ZmkvHPggvWAWHLUJr3qmEIgvytOok0hEP12P9ws5ZQ== Subject: Re: [RFC v3 2/3] interconnect: Add basic event tracing To: Steven Rostedt Cc: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, rjw@rjwysocki.net, robh+dt@kernel.org, khilman@baylibre.com, mturquette@baylibre.com, vincent.guittot@linaro.org, skannan@codeaurora.org, sboyd@codeaurora.org, andy.gross@linaro.org, seansw@qti.qualcomm.com, davidai@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, Ingo Molnar References: <20170908171830.13813-1-georgi.djakov@linaro.org> <20170908171830.13813-3-georgi.djakov@linaro.org> <20170908141321.02f51e92@gandalf.local.home> From: Georgi Djakov Message-ID: Date: Fri, 8 Sep 2017 23:16:44 +0300 MIME-Version: 1.0 In-Reply-To: <20170908141321.02f51e92@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 43 On 8.09.17 г. 21:13, Steven Rostedt wrote: > On Fri, 8 Sep 2017 20:18:29 +0300 > Georgi Djakov wrote: > >> diff --git a/include/trace/events/interconnect.h b/include/trace/events/interconnect.h >> new file mode 100644 >> index 000000000000..c4a72163873c >> --- /dev/null >> +++ b/include/trace/events/interconnect.h >> @@ -0,0 +1,45 @@ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM interconnect >> + >> +#if !defined(_TRACE_INTERCONNECT_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_INTERCONNECT_H >> + >> +#include >> + >> +struct interconnect_path; >> + >> +DECLARE_EVENT_CLASS(interconnect_path, >> + >> + TP_PROTO(struct interconnect_path *path), >> + >> + TP_ARGS(path), >> + >> + TP_STRUCT__entry( >> + __field(struct interconnect_path *, path) >> + ), >> + >> + TP_fast_assign( >> + __entry->path = path; >> + ), >> + >> + TP_printk("INTERCONNECT: %p", __entry->path) > > You're passing in an interconnect_path and only recording the pointer > to it? Wouldn't it be useful to record other aspects? Like the number > of nodes, the avg and peak bw of each node? > My goal was to get just the path with some timestamps, but your suggestion sounds good. Will do it. Thanks!