Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757346AbdIIBpZ convert rfc822-to-8bit (ORCPT ); Fri, 8 Sep 2017 21:45:25 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:36699 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757209AbdIIBpX (ORCPT ); Fri, 8 Sep 2017 21:45:23 -0400 X-IronPort-AV: E=Sophos;i="5.42,364,1500966000"; d="scan'208";a="6667043" From: To: CC: , , , , , , , Subject: RE: [PATCH RFC 3/5] Add KSZ8795 switch driver Thread-Topic: [PATCH RFC 3/5] Add KSZ8795 switch driver Thread-Index: AdMoGw7chwKpH5nHQDyZLhGSoYClOwAA0svAACf0VAAAAsLgkAAXu/yAAAb8AcA= Date: Sat, 9 Sep 2017 01:44:37 +0000 Message-ID: <93AF473E2DA327428DE3D46B72B1E9FD41123010@CHN-SV-EXMX02.mchp-main.com> References: <93AF473E2DA327428DE3D46B72B1E9FD41121A87@CHN-SV-EXMX02.mchp-main.com> <20170908091856.GB17738@amd> <93AF473E2DA327428DE3D46B72B1E9FD41121E3D@CHN-SV-EXMX02.mchp-main.com> <20170908215735.GF27428@amd> In-Reply-To: <20170908215735.GF27428@amd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 30 > -----Original Message----- > From: Pavel Machek [mailto:pavel@ucw.cz] > Sent: Friday, September 08, 2017 2:58 PM > To: Tristram Ha - C24268 > Cc: andrew@lunn.ch; muvarov@gmail.com; nathan.leigh.conrad@gmail.com; > vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - > C21699 > Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver > > Hi! > > > > > + default: > > > > + processed = false; > > > > + break; > > > > + } > > > > + if (processed) > > > > + *val = data; > > > > +} > > > > > > Similar code will be needed by other drivers, right? > > > > Although KSZ8795 and KSZ8895 may use the same code, the other > > chips will have different code. > > Ok, please make sure code is shared between these two. The exact function probably cannot be shared between KSZ8795 and KSZ8895 drivers because although the register constants look the same but their exact locations are different in the 2 chips.