Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757408AbdIIHOz (ORCPT ); Sat, 9 Sep 2017 03:14:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33826 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757224AbdIIHOy (ORCPT ); Sat, 9 Sep 2017 03:14:54 -0400 Date: Sat, 9 Sep 2017 09:14:51 +0200 From: Greg KH To: Harsha Sharma Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: unisys: visorbus: Declared char * array as static const Message-ID: <20170909071451.GA27010@kroah.com> References: <1504940442-27511-1-git-send-email-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504940442-27511-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 28 On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote: > State explicitly that individual entries in array will not change. > > Signed-off-by: Harsha Sharma > --- > drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c > index 6d4498f..6f2a010 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -1162,7 +1162,7 @@ static ssize_t deviceenabled_store(struct device *dev, > struct controlvm_message_packet *cmd = &req->msg.cmd; > char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40], > env_func[40]; > - char *envp[] = { > + static const char * const envp[] = { Are you _sure_ about this? Why make it static? That seems a bit "odd", don't you think? You need a lot more changelog text to get everyone to agree that this is ok to do... Also, you forgot to cc: the actual maintainers of this code... thanks, greg k-h