Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757440AbdIIKJ4 (ORCPT ); Sat, 9 Sep 2017 06:09:56 -0400 Received: from mail.kdab.com ([176.9.126.58]:33142 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbdIIKJz (ORCPT ); Sat, 9 Sep 2017 06:09:55 -0400 From: Milian Wolff To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra Subject: Re: [PATCH 1/4] perf ui progress: Make sure we always define step value Date: Sat, 09 Sep 2017 12:09:51 +0200 Message-ID: <2754094.RboYHdk7o7@agathebauer> Organization: KDAB (Deutschland) GmbH&Co KG, a KDAB Group company In-Reply-To: <20170908132642.GA26336@kernel.org> References: <20170908120510.22515-1-jolsa@kernel.org> <8050280.N0YfCng2Hd@agathebauer> <20170908132642.GA26336@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 52 On Freitag, 8. September 2017 15:26:42 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu: > > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > > > +++ b/tools/perf/ui/progress.c > > > @@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64 > > > adv) > > > > > > void ui_progress__init(struct ui_progress *p, u64 total, const char > > > *title) > > > > > > { > > > > > > p->curr = 0; > > > > > > - p->next = p->step = total / 16; > > > + p->next = p->step = total / 16 ?: 1; > > > > > > p->total = total; > > > p->title = title; > > > > This is a GNU extension, does this compile with clang? > > Huh? > > [acme@jouet linux]$ find tools/ -name "*.[ch]"| xargs grep ?: | wc -l > 64 > [acme@jouet linux]$ find . -name "*.[ch]"| xargs grep ?: | wc -l > 725 > [acme@jouet linux]$ > > And yes, tools/perf/ is built with clang regularly, I use containers to > test build the tools/{perf,lib} codebase with gcc and clang on almost > all distros, things like: OK, thanks for the clarification. I was wondering because I didn't know about this syntax. Googling I found this: https://en.wikipedia.org/wiki/%3F:#C Quote: > A GNU extension to C allows omitting the second operand, and using implicitly the first operand as the second also: > > a = x ? : y; Cheers -- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts