Date: Sat, 9 Sep 2017 07:01:11 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Badhri Jagan Sridharan <badhri@google.com>, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos
Message-ID: <20170909140111.GA31517@roeck-us.net>
References: <20170908012214.19047-1-Badhri@google.com>
 <20170908012214.19047-2-Badhri@google.com>
 <20170908093629.ob7fnaxlsbrmjksv@mwanda>
 <CAPTae5Kt4eZdEX-4GNYnxUApS20FMTbQKPod8xkfSj40EfazjQ@mail.gmail.com>
 <20170908194155.4jp2jrwfdcf2b3wb@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170908194155.4jp2jrwfdcf2b3wb@mwanda>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 956
Lines: 22

On Sat, Sep 09, 2017 at 11:48:48AM +0300, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote:
> > >>       /*
> > >> -      * Select the source PDO providing the most power while staying within
> > >> -      * the board's voltage limits. Prefer PDO providing exp
> > >> +      * Select the source PDO providing the most power which has a
> > >> +      * matchig sink cap. Prefer PDO providing exp
> > >            ^^^^^^^                      ^^^^^^^^^^^^^
> > > "matching".  What does "providing exp" mean?
> > 
> > Actually that was moved forward from the existing code.
> > So not sure what that means ? I can remove it, if needed.
> > 
> 
> If I can't understand it, it probably means that I don't have any
> background knowledge, but if you can't understand it then probably no
> one can.  :P  Feel free to delete.
> 
Agreed. I don't recall what it means either ;-). Most likely something
got lost.

Guenter