Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757634AbdIIQvA (ORCPT ); Sat, 9 Sep 2017 12:51:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42626 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630AbdIIQu7 (ORCPT ); Sat, 9 Sep 2017 12:50:59 -0400 Date: Sat, 9 Sep 2017 18:50:56 +0200 From: Greg KH To: Harsha Sharma Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar Message-ID: <20170909165056.GA6145@kroah.com> References: <1504975177-11843-1-git-send-email-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504975177-11843-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 287 Lines: 11 On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote: > This coding style (foo *bar) is more common for the kernel code. You also did something else in this patch that you did not mention here, which is not ok :( Remember, only one type of thing per patch. thanks, greg k-h