Date: Sat, 9 Sep 2017 21:37:50 +0200
From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Markus Trippelsdorf <markus@trippelsdorf.de>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, Rik van Riel <riel@redhat.com>
Subject: Re: Current mainline git (24e700e291d52bd2) hangs when building e.g.
 perf
Message-ID: <20170909193750.l5o5xtquogmscmom@pd.tnic>
References: <20170909163225.GA290@x4>
 <20170909170537.6xmxtzwripplhhwi@pd.tnic>
 <20170909172352.GA290@x4>
 <20170909173633.4ttfk7maooxkcwum@pd.tnic>
 <20170909181445.GA281@x4>
 <CA+55aFwCSaY2qZdt9SC+hhXOz9V=z63=uzOYgWNxKJ5kgnXCbg@mail.gmail.com>
 <20170909182952.itqad4ryngjwrgqf@pd.tnic>
 <CA+55aFzxsKzuYKMCXQA+54GUhRzEMCtwYWdj+RTDv7LHUhVj4Q@mail.gmail.com>
 <20170909190948.xydyega7i2rjnlqt@pd.tnic>
 <CALCETrXp=WVhMasO=xvNy556CoBgDqJx6xEfN3jdTJOJB4LFUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrXp=WVhMasO=xvNy556CoBgDqJx6xEfN3jdTJOJB4LFUg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1409
Lines: 32

On Sat, Sep 09, 2017 at 12:28:30PM -0700, Andy Lutomirski wrote:
> I propose the following fix.  If PCID is on, then, in
> enter_lazy_tlb(), we switch to init_mm with the no-flush flag set.
> (And we give init_mm its own dedicated ASID to keep it simple and fast
> -- no need to use the LRU ASID mapping to assign one dynamically.)  We
> clear the bit in mm_cpumask.  That is, we more or less just skip the
> whole lazy TLB optimization and rely on PCID CPUs having reasonably
> fast CR3 writes.  No extra IPIs.  I suppose I need to benchmark this.
> It will certainly slow down workloads that rapidly toggle between a
> user thread and a kernel thread because it forces serialization on
> each mm switch, but maybe that's not so bad.

Sounds ok so far.

> If PCID is off, then we leave the old CR3 value when we go lazy, and
> we also leave the flag in mm_cpumask set.  When a flush is requested,
> we send out the IPI and switch to init_mm (and flush because we have
> no choice).  IOW, the no-PCID behavior goes back to what it used to
> be.

Ok, question: why can't we load the new CR3 value too, immediately? Or
are we saying, we might get to return to the same CR3 we had before we
were lazy so we won't need to do an unnecessary CR3 write with the same
value. A microoptimization, if you will.

Yes?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.