Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751014AbdIIUKI (ORCPT ); Sat, 9 Sep 2017 16:10:08 -0400 Received: from mx3.wp.pl ([212.77.101.10]:44387 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbdIIUKH (ORCPT ); Sat, 9 Sep 2017 16:10:07 -0400 Date: Sat, 9 Sep 2017 22:10:02 +0200 From: Jakub Kicinski To: Dmitry Torokhov Cc: LKML , Greg Kroah-Hartman Subject: Re: [bisected] Re: Module removal-related regression? Message-ID: <20170909221002.54a0b6da@cakuba.netronome.com> In-Reply-To: References: <20170909194121.39cd9f56@cakuba.netronome.com> <20170909212732.5bc98775@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: fb35085588c0edba8599d99acea1fcd0 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [YYOE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 41 On Sat, 9 Sep 2017 12:55:51 -0700, Dmitry Torokhov wrote: > On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski wrote: > > On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote: > >> Hi! > >> > >> I'm having trouble with modules on linux/master. rmmod succeeds but the > >> module is still loaded and the refcount goes to 1: > >> > >> #rmmod nfp; insmod ./src/nfp.ko nfp_pf_netdev=0 ; \ > >> /opt/netronome/bin/nfp-hwinfo -n 2 assembly.partno \ > >> lsmod | grep nfp; \ > >> rmmod nfp; \ > >> lsmod | grep nfp > >> nfp 249856 0 > >> nfp 200704 1 > >> > >> If I rmmod again the module will be actually unloaded. The user space > >> is mostly Ubuntu 14.04. Has anyone seen this? I'm trying to bisect > >> now... > > > > Got 'em! > > > > commit 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (HEAD, refs/bisect/bad) > > Author: Dmitry Torokhov > > Date: Wed Jul 19 17:24:30 2017 -0700 > > > > driver core: emit uevents when device is bound to a driver > > Does it happen with all modules or only nfp one? > > It seems to work here: > > dtor@dtor-glaptop3:~ $ lsmod | grep psmouse > psmouse 135168 0 > dtor@dtor-glaptop3:~ $ sudo rmmod psmouse > dtor@dtor-glaptop3:~ $ lsmod | grep psmouse > dtor@dtor-glaptop3:~ $ sudo modprobe psmouse Yes, and only if FW is loaded/requested successfully. Hmm... I'm building a kernel with more debug, any particular suggestions?