Message-ID: <1504995031.26889.0.camel@perches.com>
Subject: Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
        Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
        linux-kernel@vger.kernel.org
Date: Sat, 09 Sep 2017 15:10:31 -0700
In-Reply-To: <20170909165056.GA6145@kroah.com>
References: <1504975177-11843-1-git-send-email-harshasharmaiitr@gmail.com>
         <20170909165056.GA6145@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 380
Lines: 12

On Sat, 2017-09-09 at 18:50 +0200, Greg KH wrote:
> On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote:
> > This coding style (foo *bar) is more common for the kernel code.
> 
> You also did something else in this patch that you did not mention here,
> which is not ok :(

what is that?

> Remember, only one type of thing per patch.

Seemed like only one thing to me.