Date: Sun, 10 Sep 2017 16:33:19 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants
Message-ID: <20170910133319.urmptwfq7qifjlay@yury-thinkpad>
References: <1505040523-31230-1-git-send-email-geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1505040523-31230-1-git-send-email-geert@linux-m68k.org>
User-Agent: NeoMutt/20170113 (1.7.2)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2017 13:33:30.1724 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB1453
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1598
Lines: 44

On Sun, Sep 10, 2017 at 12:48:43PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> 
>     lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "ULL" suffix to fix this.
> 
> Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks.
Acked-by: Yury Norov <ynorov@caviumnetworks.com>

> ---
>  lib/test_bitmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
>  	BITMAP_FROM_U64(0x22222222),
>  	BITMAP_FROM_U64(0xffffffff),
>  	BITMAP_FROM_U64(0xfffffffe),
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const unsigned long exp2[] __initconst = {
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> -- 
> 2.7.4