Message-ID: <1505052969.22023.1.camel@perches.com>
Subject: Re: [PATCH 1/1] scripts/checkpatch.pl: avoid false warning missing
 break
From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Date: Sun, 10 Sep 2017 07:16:09 -0700
In-Reply-To: <20170910075249.13997-1-xypron.glpk@gmx.de>
References: <20170910075249.13997-1-xypron.glpk@gmx.de>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 30

On Sun, 2017-09-10 at 09:52 +0200, Heinrich Schuchardt wrote:
> void foo(int a)
> 	switch (a) {
> 	case 'h':
> 		fun1();
> 		exit(1);
> 	default:
> }
> 
> creates a warning
> Possible switch case/default not preceded by break
> or fallthrough comment
> 
> exit( should be treated like return.

OK, but

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4361,7 +4361,7 @@ sub process {
>  				next if ($fline =~ /^.[\s$;]*$/);
>  				$has_statement = 1;
>  				$count++;
> -				$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|return\b|goto\b|continue\b)/);
> +				$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|exit\(\b|return\b|goto\b|continue\b)/);

exit\s*\(

Although this could have a false negative
on some code.