Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496AbdIJTg4 (ORCPT ); Sun, 10 Sep 2017 15:36:56 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:8033 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbdIJTgz (ORCPT ); Sun, 10 Sep 2017 15:36:55 -0400 X-IronPort-AV: E=Sophos;i="5.42,374,1500933600"; d="scan'208";a="290382285" Date: Sun, 10 Sep 2017 21:36:53 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Harsha Sharma cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*' In-Reply-To: <28be543667f44c31e38872ec4a96bad8c167e3d8.1505052882.git.harshasharmaiitr@gmail.com> Message-ID: References: <28be543667f44c31e38872ec4a96bad8c167e3d8.1505052882.git.harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3137 Lines: 79 On Sun, 10 Sep 2017, Harsha Sharma wrote: > Use one space around most binary operators > > Signed-off-by: Harsha Sharma Acked-by: Julia Lawall > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > index 7f22ca9..18f0ac2 100644 > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > @@ -222,7 +222,7 @@ > /* BIT4 - RF, 0: non-support, 1: support */ > /* BIT5 - RF_TXPWR_TRACK, 0: non-support, 1: support */ > /* BIT6 - RF_TXPWR_LMT, 0: non-support, 1: support */ > -static int rtw_load_phy_file = (BIT2|BIT6); > +static int rtw_load_phy_file = (BIT2 | BIT6); > module_param(rtw_load_phy_file, int, 0644); > MODULE_PARM_DESC(rtw_load_phy_file,"PHY File Bit Map"); > static int rtw_decrypt_phy_file = 0; > @@ -440,12 +440,12 @@ u16 rtw_recv_select_queue(struct sk_buff *skb) > u32 priority; > u8 *pdata = skb->data; > > - memcpy(ð_type, pdata+(ETH_ALEN<<1), 2); > + memcpy(ð_type, pdata + (ETH_ALEN << 1), 2); > > switch (be16_to_cpu(eth_type)) { > case ETH_P_IP: > > - piphdr = (struct iphdr *)(pdata+ETH_HLEN); > + piphdr = (struct iphdr *)(pdata + ETH_HLEN); > > dscp = piphdr->tos & 0xfc; > > @@ -561,7 +561,7 @@ struct net_device *rtw_init_netdev(struct adapter *old_padapter) > pnetdev->netdev_ops = &rtw_netdev_ops; > > /* pnetdev->tx_timeout = NULL; */ > - pnetdev->watchdog_timeo = HZ*3; /* 3 second timeout */ > + pnetdev->watchdog_timeo = HZ * 3; /* 3 second timeout */ > pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def; > > /* step 2. */ > @@ -748,7 +748,7 @@ u8 rtw_reset_drv_sw(struct adapter *padapter) > pmlmepriv->LinkDetectInfo.TrafficTransitionCount = 0; > pmlmepriv->LinkDetectInfo.LowPowerTransitionCount = 0; > > - _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY |_FW_UNDER_LINKING); > + _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING); > > pwrctrlpriv->pwr_state_check_cnts = 0; > > @@ -935,7 +935,7 @@ static int _rtw_drv_register_netdev(struct adapter *padapter, char *name) > goto error_register_netdev; > } > > - DBG_871X("%s, MAC Address (if%d) = " MAC_FMT "\n", __func__, (padapter->iface_id+1), MAC_ARG(pnetdev->dev_addr)); > + DBG_871X("%s, MAC Address (if%d) = " MAC_FMT "\n", __func__, (padapter->iface_id + 1), MAC_ARG(pnetdev->dev_addr)); > > return ret; > > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/28be543667f44c31e38872ec4a96bad8c167e3d8.1505052882.git.harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >