From: "Rangankar, Manish" <Manish.Rangankar@cavium.com>
To: Christos Gkekas <chris.gekas@gmail.com>,
        Dept-Eng QLogic Storage Upstream 
        <QLogic-Storage-Upstream@cavium.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bnx2i: Clean up unused pointers in bnx2i_hwi
Thread-Topic: [PATCH] bnx2i: Clean up unused pointers in bnx2i_hwi
Thread-Index: AQHTKi79cwWVk09MkEiYT6+Xvi8i46KvivwA
Date: Mon, 11 Sep 2017 05:48:24 +0000
Message-ID: <D5DC2129.3D3F8%manish.rangankar@cavium.com>
References: <1505045934-16272-1-git-send-email-chris.gekas@gmail.com>
In-Reply-To: <1505045934-16272-1-git-send-email-chris.gekas@gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB91E3001CCA2C4BBEFF3678774B1DE1@namprd07.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2017 05:48:24.8000
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2593
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8B5md7U031243
Content-Length: 2925
Lines: 91


On 10/09/17 5:48 PM, "Christos Gkekas" <chris.gekas@gmail.com> wrote:

>Pointers bnx2i_cmd are set but never used, so they can be removed.
>
>Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c
>b/drivers/scsi/bnx2i/bnx2i_hwi.c
>index 42921db..e3f22cb 100644
>--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
>+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
>@@ -332,12 +332,10 @@ static void
>bnx2i_ring_dbell_update_sq_params(struct bnx2i_conn *bnx2i_conn,
> int bnx2i_send_iscsi_login(struct bnx2i_conn *bnx2i_conn,
> 			   struct iscsi_task *task)
> {
>-	struct bnx2i_cmd *bnx2i_cmd;
> 	struct bnx2i_login_request *login_wqe;
> 	struct iscsi_login_req *login_hdr;
> 	u32 dword;
> 
>-	bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> 	login_hdr = (struct iscsi_login_req *)task->hdr;
> 	login_wqe = (struct bnx2i_login_request *)
> 						bnx2i_conn->ep->qp.sq_prod_qe;
>@@ -391,12 +389,10 @@ int bnx2i_send_iscsi_tmf(struct bnx2i_conn
>*bnx2i_conn,
> 	struct iscsi_tm *tmfabort_hdr;
> 	struct scsi_cmnd *ref_sc;
> 	struct iscsi_task *ctask;
>-	struct bnx2i_cmd *bnx2i_cmd;
> 	struct bnx2i_tmf_request *tmfabort_wqe;
> 	u32 dword;
> 	u32 scsi_lun[2];
> 
>-	bnx2i_cmd = (struct bnx2i_cmd *)mtask->dd_data;
> 	tmfabort_hdr = (struct iscsi_tm *)mtask->hdr;
> 	tmfabort_wqe = (struct bnx2i_tmf_request *)
> 						bnx2i_conn->ep->qp.sq_prod_qe;
>@@ -463,12 +459,10 @@ int bnx2i_send_iscsi_tmf(struct bnx2i_conn
>*bnx2i_conn,
> int bnx2i_send_iscsi_text(struct bnx2i_conn *bnx2i_conn,
> 			  struct iscsi_task *mtask)
> {
>-	struct bnx2i_cmd *bnx2i_cmd;
> 	struct bnx2i_text_request *text_wqe;
> 	struct iscsi_text *text_hdr;
> 	u32 dword;
> 
>-	bnx2i_cmd = (struct bnx2i_cmd *)mtask->dd_data;
> 	text_hdr = (struct iscsi_text *)mtask->hdr;
> 	text_wqe = (struct bnx2i_text_request *) bnx2i_conn->ep->qp.sq_prod_qe;
> 
>@@ -541,11 +535,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn
>*bnx2i_conn,
> 			    char *datap, int data_len, int unsol)
> {
> 	struct bnx2i_endpoint *ep = bnx2i_conn->ep;
>-	struct bnx2i_cmd *bnx2i_cmd;
> 	struct bnx2i_nop_out_request *nopout_wqe;
> 	struct iscsi_nopout *nopout_hdr;
> 
>-	bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> 	nopout_hdr = (struct iscsi_nopout *)task->hdr;
> 	nopout_wqe = (struct bnx2i_nop_out_request *)ep->qp.sq_prod_qe;
> 
>@@ -602,11 +594,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn
>*bnx2i_conn,
> int bnx2i_send_iscsi_logout(struct bnx2i_conn *bnx2i_conn,
> 			    struct iscsi_task *task)
> {
>-	struct bnx2i_cmd *bnx2i_cmd;
> 	struct bnx2i_logout_request *logout_wqe;
> 	struct iscsi_logout *logout_hdr;
> 
>-	bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> 	logout_hdr = (struct iscsi_logout *)task->hdr;
> 
> 	logout_wqe = (struct bnx2i_logout_request *)
>-- 
>2.7.4

Thanks,

Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>