Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751214AbdIKO2O (ORCPT ); Mon, 11 Sep 2017 10:28:14 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:47787 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdIKO2N (ORCPT ); Mon, 11 Sep 2017 10:28:13 -0400 From: "Steve Wise" To: "'Colin King'" , "'Steve Wise'" , "'Doug Ledford'" , "'Sean Hefty'" , "'Hal Rosenstock'" , Cc: , References: <20170911114231.22893-1-colin.king@canonical.com> In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com> Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp Date: Mon, 11 Sep 2017 09:28:14 -0500 Message-ID: <006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGs4oH8gk7d2Q34Gq9/H5y+rHZIUaL8TuAg Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 15 > > From: Colin Ian King > > sqp is being initialised when it is being declared and then updated > a little later on making the first initialization redundant. Clean > this up by initializing ptr and sqp at their declaration. > > Cleans up warning: "warning: Value stored to 'sqp' during its > initialization is never read" > > Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as > needed on flush") > Signed-off-by: Colin Ian King Acked-by: Steve Wise