Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751258AbdIKOdR (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Sep 2017 10:33:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25181 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751038AbdIKOdQ (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Mon, 11 Sep 2017 10:33:16 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 292612B4D45
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=acme@redhat.com
Date: Mon, 11 Sep 2017 11:33:12 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Milian Wolff <milian.wolff@kdab.com>, acme@kernel.org,
        Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Yao Jin <yao.jin@linux.intel.com>
Subject: Re: [PATCH] perf: support running perf binaries with a dash in their
 name
Message-ID: <20170911143312.GD5054@redhat.com>
References: <20170911111422.31903-1-milian.wolff@kdab.com>
 <b7c2b440-f781-19ae-ebc7-7fba93bb4618@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b7c2b440-f781-19ae-ebc7-7fba93bb4618@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 11 Sep 2017 14:33:16 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 824
Lines: 27

Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> On 9/11/17 4:14 AM, Milian Wolff wrote:
> > Previously the part behind "perf-" was interpreted as an internal
> > perf command. If the suffix could not be handled, the execution
<SNIP>
> > --- a/tools/perf/perf.c
> > -		fprintf(stderr, "cannot handle %s internally", cmd);
> > -		goto out;
> > +		// if the command is handled, the above function does not return
> > +		// undo changes and fall through in such a case
 
> Those should be /* */ not //
> 
> > +		cmd -= 5;
> > +		argv[0] = cmd;
> >  	}
> >  	if (strstarts(cmd, "trace")) {
> >  #ifdef HAVE_LIBAUDIT_SUPPORT
 
> other than that LGTM and long over due.
 
> Acked-by: David Ahern <dsahern@gmail.com>

We got those from git, agreed it should go, thanks for the Acked-by,
always welcome!

- Arnaldo