Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbdIKQIH (ORCPT ); Mon, 11 Sep 2017 12:08:07 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:35378 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbdIKQIF (ORCPT ); Mon, 11 Sep 2017 12:08:05 -0400 X-Google-Smtp-Source: AOwi7QBkER25UyLkvmUsJ7P9bKtokNQB8St70vm+7YIXufHbrdSHSgpCGysBj9aKzzcINlfrRUeikV83C4HA9njQrFg= MIME-Version: 1.0 In-Reply-To: <20170911160449.GA11886@kroah.com> References: <1505145571-11248-1-git-send-email-srishtishar@gmail.com> <20170911160449.GA11886@kroah.com> From: Srishti Sharma Date: Mon, 11 Sep 2017 21:38:04 +0530 Message-ID: Subject: Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock To: Greg KH Cc: Gilad Ben-Yossef , Linux Crypto Mailing List , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Linux kernel mailing list , outreachy-kernel@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 34 On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> index e5c2f92..7d77941 100644 >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> dma_addr_t dummy_comp_buff_dma; >> struct cc_hw_desc monitor_desc; >> >> - volatile unsigned long monitor_lock; >> + unsigned long monitor_lock; > > While volatile is not right, odds are, this is still totally wrong as > well. How about using a "real" lock instead? I tried to find where is this variable being used in the code, but I didn't find any usage of it . It might be an important attribute of this structure definition but, I don't see it's value being set to anything or being used somewhere . Regards, Srishti > > thanks, > > greg k-h