Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751905AbdIKRYw (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Sep 2017 13:24:52 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:57840 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751015AbdIKRYv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Sep 2017 13:24:51 -0400
Date: Mon, 11 Sep 2017 10:24:49 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Todd Kjos <tkjos@google.com>, Todd Kjos <tkjos@android.com>,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        lkml <linux-kernel@vger.kernel.org>, Martijn Coenen <maco@google.com>,
        Xu Yiping <xuyiping@hisilicon.com>, gengyanping@hisilicon.com,
        shiwanglai@hisilicon.com, John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] binder: fix memory corruption in binder_transaction
 binder
Message-ID: <20170911172449.GB21108@kroah.com>
References: <20170905172152.36227-1-tkjos@google.com>
 <CAMi1Hd2AcD9n6n0T4OdX-2QouTSwPH4vhk4qoGQHJp-fWFtQNw@mail.gmail.com>
 <CAHRSSEwVSHSoYJc8JEaAkNwG+v5Fgaq4sO7GZ7otHzyv9m+qFg@mail.gmail.com>
 <CAHRSSEyOaCpN1iZY2q3B7m8BMk3F5cH=mPzSyK4H6DGV12BdjA@mail.gmail.com>
 <CAMi1Hd3qrjryXZCCGbET20fJ+0m8C5ZxoghnJdOP225L82wpdg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMi1Hd3qrjryXZCCGbET20fJ+0m8C5ZxoghnJdOP225L82wpdg@mail.gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1132
Lines: 28

On Mon, Sep 11, 2017 at 10:25:14PM +0530, Amit Pundir wrote:
> Hi Todd,
> 
> On 11 September 2017 at 21:10, Todd Kjos <tkjos@google.com> wrote:
> > (resend in plain-text mode -- sorry about that)
> >
> > Amit,
> >
> > Are you sure this patch is the culprit? That is pretty surprising
> > since this change can only be hit in a uncommon case (the target node
> > is valid when we start creating the transaction, but dead when we
> > check right before sending it) so it is unlikely to be hit during a
> > normal boot. It also fixes a corruption -- so if you were actually
> > hitting the case, it would likely have caused issues before and not
> > now. Take a look at it and see if you think it is really possible.
> >
> > I just booted hikey to Android with this patch 10 times in a row with
> > no issues (used hikey-linaro 4.9 kernel which has this patch).
> 
> Sorry for not being clear enough in the bug report. android-4.9 is
> fine, I see this issue on linux mainline tree with this patch.

What exact kernel release?  A number of binder fixes have recently
landed in the stable trees, and in Linus's tree.

thanks,

greg k-h