Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbdIKRcZ (ORCPT ); Mon, 11 Sep 2017 13:32:25 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58341 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbdIKRcY (ORCPT ); Mon, 11 Sep 2017 13:32:24 -0400 From: Anju T Sudhakar To: mpe@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, maddy@linux.vnet.ibm.com, hemant@linux.vnet.ibm.com, anju@linux.vnet.ibm.com Subject: [PATCH] powerpc/perf: Fix for core/nest imc call trace on cpuhotplug Date: Mon, 11 Sep 2017 23:02:14 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-MML: disable x-cbid: 17091117-0040-0000-0000-00000355B298 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17091117-0041-0000-0000-00000CD5E1DE Message-Id: <1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-11_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709110264 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 35 Nest/core pmu units are enabled only when it is used. A reference count is maintained for the events which uses the nest/core pmu units. Currently in *_imc_counters_release function a WARN() is used for notification of any underflow of ref count. Replace WARN() with a pr_info since it is an overkill. Signed-off-by: Anju T Sudhakar Acked-by: Madhavan Srinivasan --- arch/powerpc/perf/imc-pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c index 9ccac86..4d523d0 100644 --- a/arch/powerpc/perf/imc-pmu.c +++ b/arch/powerpc/perf/imc-pmu.c @@ -409,7 +409,7 @@ static void nest_imc_counters_release(struct perf_event *event) return; } } else if (ref->refc < 0) { - WARN(1, "nest-imc: Invalid event reference count\n"); + pr_info("nest-imc: Invalid event reference count\n"); ref->refc = 0; } mutex_unlock(&ref->lock); @@ -656,7 +656,7 @@ static void core_imc_counters_release(struct perf_event *event) return; } } else if (ref->refc < 0) { - WARN(1, "core-imc: Invalid event reference count\n"); + pr_info("core-imc: Invalid event reference count\n"); ref->refc = 0; } mutex_unlock(&ref->lock); -- 2.7.4