Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbdIKRos (ORCPT ); Mon, 11 Sep 2017 13:44:48 -0400 Received: from mail-dm3nam03on0047.outbound.protection.outlook.com ([104.47.41.47]:11040 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751266AbdIKRop (ORCPT ); Mon, 11 Sep 2017 13:44:45 -0400 Authentication-Results: spf=pass (sender IP is 204.128.141.24) smtp.mailfrom=infinera.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=infinera.com; From: Joakim Tjernlund To: "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "bmeng.cn@gmail.com" , "mika.westerberg@linux.intel.com" , "cyrille.pitchen@wedev4u.fr" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "boris.brezillon@free-electrons.com" , "marek.vasut@gmail.com" , "richard@nod.at" CC: "sr@denx.de" Subject: Re: [PATCH v2 00/10] spi-nor: intel-spi: Various fixes and enhancements Thread-Topic: [PATCH v2 00/10] spi-nor: intel-spi: Various fixes and enhancements Thread-Index: AQHTKuG9udHueSHjj0aeIjY3IlPvcKKwatAA Date: Mon, 11 Sep 2017 17:44:31 +0000 Message-ID: <1505151868.31322.98.camel@infinera.com> References: <1505122921-5534-1-git-send-email-bmeng.cn@gmail.com> In-Reply-To: <1505122921-5534-1-git-send-email-bmeng.cn@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.100.99.93] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <282A0314ABD70E4AB250F062F884B4C5@infinera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:204.128.141.24;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(2980300002)(438002)(24454002)(199003)(189002)(377424004)(2906002)(50986999)(2900100001)(8676002)(33646002)(8746002)(53416004)(8936002)(106466001)(77096006)(7736002)(2201001)(4326008)(39060400002)(76176999)(54356999)(6246003)(356003)(7636002)(2950100002)(103116003)(305945005)(50466002)(5660300001)(14454004)(102836003)(6116002)(3846002)(23756003)(189998001)(72206003)(47776003)(246002)(229853002)(36756003)(2501003)(7416002)(478600001)(86362001)(921003)(1121003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR10MB0537;H:owa.infinera.com;FPR:;SPF:Pass;PTR:outgoingmail2.infinera.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2NAM03FT011;1:LMPS+0lI1pbUeCuxH+xUg4TcqHi1j7Qh0hFe2MHIIC04G9o0BWlTAEyRcn0NWbsuRn9v7zCdaywyWrRmWDczgAb98sLtzkzY8oI/pvGEJboFkCB+eEUh+1tgPfuSpS0c X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 324e5781-87c9-41ca-e319-08d4f93cc2b8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR10MB0537; X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0537;3:ZAdOdzR82oevlh9EITryK+Bjxm1S+DcRKxEapJiixVLz5R0XpeEPJ1YCEhzjbZzbVPET9IBvJa18tSfJ+IVrbQQb3vBFvTPdmuDXyKZHg+entNs6aEihZvl+6zYKn/oP5tAQrZd+Q8G73jaA5vqkBC8N4LFLJ8jqx/wKDb5M4DrF3nYKFna2HpjFjG884ih8OUr/B9Yqdu+/k6sO7cnRU5GbXtnX2xsJecLj4+GA58l7vr31VJQlrjixOoGvw9J/F3s8ElpQ6oL83phkd6otLZQbgiLzGYbrXuUuj+1hOlqkuNbdxwvGnL2uGAo2IF4fFG0IyLRfWDU3wU39TMffYIpzF6jVruuWQs29ieTF+QI=;25:N7o0fnrAVrSeDH/fI32p1hnVwcF61apk+qaszOFnF/zP0svkQUukmRHNNnJVuTjh5KB8vPZRiXpRrbw+GTg0e/fbKpyicU3zKLnJo4i1OGODwUaWW4DFIAyD3BJv7PhvP2EH5vl45VrDXSZtZnJgwbprMsi4LwJUwFNTR+46Rl4pwsPIuBxgzK+TnGb+3LJVDy8+tm4LQUtT2CGubQlGt37MG7th4UJ4mduDwhbYXzZ52NALkkXh0xwSYGCzyZ9Aq+gMlxp4WElBlo1T+V/SDsQIRYXWw4Ssg3NLJrvMWYj0bxhWdjl3pyMz8mDL8iEbxwK1imuRCMRiVvhGG8TICw== X-MS-TrafficTypeDiagnostic: CY1PR10MB0537: X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0537;31:NM3XZ0cKzaiilyuPuseqEdNl8Iv4xhbV2ArqAW2SbTDCEnsEs9nNjq2h0m0vSFRepzziGQo68oV/zEcnW7P7vRLCxw6cziICQtk49VnDd0sc9oixkQuCIEgx4blAezQ0Z/SHBs7K6ncZUQZ5J5C0jfJzuVxteaw8C4pjcSQcVHXh0l1zjQ6JZuOFT3uRA4T407xgyBOt+JH7Na4Dr687RZKi2KQg9QBCPeT2JGStiiQ=;20:bomKVPRmb1Z7BWsU6dKBURjYg4cpemzuuAPZERsZpKO7DrW1AGYtY/nj+29sXH0486rEbNMhKv5EcWDQoLgfCTqHC8e1BMa+y2etYClKKp2ao+PyXfSdM9OeZe4x/8cNdy81BKB1HTgOdZ7V6jTOyl+pECRGpEs6zlqsJxl92y+CXuUn8dkXGrmurbnUbeJpr8Z9ouTyloGZLxx2i/Y5e0UEGufF+6+bNnbmyBVOPXWqWOG/V3larVr8fW+EjfLCG8bKTKWpw84SpgVy/DY/WNqSEjW7Ntf6aalDxZHl6zrZrcYBbuihcMZ1T2vNwXua74pOGm93P3ZqK19Zk3gtovExbN1SBwj2xp9Q8WhMJPMzC4DM7i3gKhUnSFPhwlCIqrYDoWbrW+ivbsudnzF7u/QgwxNDZzz3g4IErRpihoE=;4:JpZGJVsRRTPOsBCPtIpb+oG2f6hPuAIIGXpZwcUaAtk82jU9ub6A+Q3HqSQ+/WIm4sEVllSJTPEUWWGFaodvmrzd9fCDxJiK8N/+CK8wGJmudLEVQzwjqNijyQZ/aKgWb31D5FwN4cjKXWSDOwrvB/h6WS9UBfTrkDSAL8qFKodt1aMqF8WnMVwGO65YHYjv5Dda3b3sUFUv5JIZPjQ4n24R14yhpfPVl6I1Gr4nYfQdV1TZyjJ6Ca3kyRgUSyXR X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR10MB0537;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR10MB0537; X-Forefront-PRVS: 04270EF89C X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;CY1PR10MB0537;23:nRFIHuUCxml3FpK85huvIVpHCcVozgjWrZsh8+?= =?iso-8859-15?Q?g6rsKq7twVhzBgbknNJNm1GiSzxwPSrM7S4rDLS0f0g+M1jlG4Sjggm4E?= =?iso-8859-15?Q?eYEGw/uPZX1/a3AyyXHkiAdfQd7gwrB2IHymivcTYKrVb70Du1p4oSMG5?= =?iso-8859-15?Q?ISCs8W/t24rKEEC4wzg7c0JbRO6qmKB9rftesrVI4Kg8MI+jpef/dCOQs?= =?iso-8859-15?Q?6S7vLHfaszeGVfSK4GeBUAviVisca4IrQXceMYijFeLct4EsmBP2zTWsc?= =?iso-8859-15?Q?SwpaAFDxQ+OYiCpEfsHpCio4nUYmcNtq7ZywwD3jGEK/tJSki78QJCDok?= =?iso-8859-15?Q?hAaCDv2Bqj6LemNBLSh+/b+0BWe1qY2qDZVjiBkHlw6oD3+jjvAYk2o5g?= =?iso-8859-15?Q?1C7cUNzIYGT9umsvYlyl+/bO5Qr4QU++iUJRUo4Sx1ZQrlb9nq7HQJiGD?= =?iso-8859-15?Q?niysBoS4pXcm81kEK8rD6J7QljcdbZPdzuc4v0s+ky2adLN+UQaRx2DoE?= =?iso-8859-15?Q?m6/TRbF2R1WapOqv9SNTKFIVJpTVlE1C0JDByRVd37xtUnlRMquPVtzW2?= =?iso-8859-15?Q?9tzUrb0ozXwmeAuw6jSRkrkx6M6lJnORw41NUr93oPjZlAI5Gn46cpjju?= =?iso-8859-15?Q?FTHB2ZTjIhB+j+OhcA/nqWK2TvffSsolgsbLtOi4W4FNkogPR7jNc7L/m?= =?iso-8859-15?Q?v14HBzxxaj42HOa31kY9SMBaLDbTdqIn04+mzKT+2UQncZOD509+LWDyT?= =?iso-8859-15?Q?BqSCPnvx6r04MDoBVWZMh7wuTX6yojTD87IEuDdU0EO3/QFxVdKB3Nxwu?= =?iso-8859-15?Q?DAqCni2P8VQ8oDavFaVtEBqcUUfC/oZ0ETfilNjB/tEmy3//FzFhIGFa+?= =?iso-8859-15?Q?f4+Qs5UUvfDIiXgzvwBlKpUKT4mhMiZpWcUoMtGFj4hn+GF+EEKSKi3yU?= =?iso-8859-15?Q?C+92wFuHu9vZRwj0algkx2wmW1VDV6eANo+vopY5SiE8Z2GcTMvLZopJS?= =?iso-8859-15?Q?GXf+RBp8Bwmk+j+dsFu4R/kvx7G/fabE0EwTxsbN5PasFFBapnJBaqKYV?= =?iso-8859-15?Q?nCsQtdegsNtNM9JUsrIuxdUIzNH9loRr/WHdlbEGKGS5ct+DFV6H9TmKw?= =?iso-8859-15?Q?rxZNzLWYakfEI9xvyQyD7b2x7Wb1BXUMMSDNZmoj743GesxsaHSybRCFw?= =?iso-8859-15?Q?Wyktn7Jc71K5qp0AP8MDiwUuV7ca1MQ7EhY+618xI0ZHD8gQzDXoBs/N3?= =?iso-8859-15?Q?sHZwU4zWSEwdCjyLE1xA0N5AtyvAzX2sADg9UC5NGseQxfyPxHwI8aSDR?= =?iso-8859-15?Q?eeA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR10MB0537;6:HtA2+qH23dhsRV6k+XCvVFnuSh2sKLTExldBQ/ZahGUbfLbtyMz3lkVxOY+quLmFPEJgT2iOloMROXDBLvYGfYl0uMcepdcglKWxW86GDP8t/LsUsyaHHTqVq/C5pX07TrSFwQmNWFuQI3T8W/K2VOFEnYrJH0pUqG8M6kFIj8y2eWB+6JhC3FN9djR5lJluyfKGgSRZqpZFUpaLGJ2ergcmZq7wgdCtwvmV5PUT2ZkXWGMetb5tFZzZAWpQs5/aLT2+JKkp+UyznASC7mwEID6tN37h6RRw3xynClJNdiK8d6jYCeCBzoxinjktAazzysTgQTXt/YxkLWNnOR0q2Q==;5:xwE9mZTVRjbv2rMRx0ZY5mOZV9eDP5Gz6pLMt7pAbuSfdIhxP+2VnyNld+R07PVH36F90uxpODL1qo5AdEpnz+xlTIzkNh18yRGRAh+qLtdKYGlP2tBVKAICO8KFtAZdxGn9ypY55zcfW8K2QXzl+g==;24:bO/GwduE+S6KvVk2eJdG7uEqYWUtp353Z+TrmbmNbrxa//XI+pcDi5b5X7Nv/1k0LaXu39iT2N4yXGmrmHR9q5pXA78ykZN7IHkEfvNHgIU=;7:ljH8l6TmEsWLwvPSICOljZSncfrCR2ENpJ0JWDiwaSfwxwLGa74QxPWb7rG0qIR5G6rNty0lag78zEs4PvN/NMyLOsZfYNLB9Zd7C9bng/L1nErj8Wa3IEpuE490yl7ldaY5hz7ck5xZ+LtLJJDv+R0NJyBSzOoHEdCoEnmwQpr/Ave2ZPDbtry7DZpGPYB6qDGHnajizgSSMHLMRybIm5vOQfEHybcO5D3fSeu1dr8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 17:44:32.5708 (UTC) X-MS-Exchange-CrossTenant-Id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;Ip=[204.128.141.24];Helo=[owa.infinera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR10MB0537 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8BHireN011752 Content-Length: 2140 Lines: 46 On Mon, 2017-09-11 at 02:41 -0700, Bin Meng wrote: > This series does several bug fixes and clean ups against the intel-spi > spi-nor driver, as well as enhancements to make the driver independent > on the underlying BIOS/bootloader. > > At present the driver uses the HW sequencer for the read/write/erase on > all supported platforms, read_reg/write_reg for BXT, and the SW sequencer > for read_reg/write_reg for BYT/LPT. The way the driver uses the HW and SW > sequencer relies on some programmed register settings and hence creates > unneeded dependencies with the underlying BIOS/bootloader. For example, > the driver unfortunately does not work as expected when booting from > Intel Baytrail FSP based bootloaders like U-Boot, as the Baytrail FSP > does not set up some SPI controller settings to make the driver happy. > Now such limitation has been removed with this series. Hi Bin Just starting to test these on Rangeley and got a question: We have two SPI flashes on CS0 resp. CS1 and the mtd driver seems to only map the first of those flashes. Is this intentional or are we missing something? Jocke > > Changes in v2: > - Add stable kernel tags in the commit message (patch [03/10]) > - Fix typo of 'operatoin' (patch [10/10]) > - Add Mika Westerberg's 'Acked-by' tag > > Bin Meng (10): > spi-nor: intel-spi: Fix number of protected range registers for > BYT/LPT > spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle > spi-nor: intel-spi: Fix broken software sequencing codes > spi-nor: intel-spi: Check transfer length in the HW/SW cycle > spi-nor: intel-spi: Use SW sequencer for BYT/LPT > spi-nor: intel-spi: Remove 'Atomic Cycle Sequence' in > intel_spi_write() > spi-nor: intel-spi: Don't assume OPMENU0/1 to be programmed by BIOS > spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW > spi-nor: intel-spi: Rename swseq to swseq_reg in 'struct intel_spi' > spi-nor: intel-spi: Fall back to use SW sequencer to erase > > drivers/mtd/spi-nor/intel-spi.c | 209 +++++++++++++++++++++++++++++----------- > 1 file changed, 151 insertions(+), 58 deletions(-) >