Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbdIKUEq (ORCPT ); Mon, 11 Sep 2017 16:04:46 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:46138 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdIKUEp (ORCPT ); Mon, 11 Sep 2017 16:04:45 -0400 X-ME-Helo: [192.168.1.10] X-ME-Date: Mon, 11 Sep 2017 22:04:44 +0200 X-ME-IP: 86.196.182.67 Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' To: Jens Axboe , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel,gmane.linux.kernel.mm,gmane.linux.kernel.janitors References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> From: Christophe JAILLET Message-ID: <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> Date: Mon, 11 Sep 2017 22:04:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 421 Lines: 15 Le 11/09/2017 à 21:52, Jens Axboe a écrit : > On 09/11/2017 01:43 PM, Christophe JAILLET wrote: >> If the 'kmalloc' fails, we must go through the existing error handling >> path. > Looks good to me, probably wants a > > Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") > > line as well. > Hi, do you want me to resend with the Fixes tag? Or will it be added if merged? CJ