Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751110AbdILBUe (ORCPT ); Mon, 11 Sep 2017 21:20:34 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6028 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbdILBUd (ORCPT ); Mon, 11 Sep 2017 21:20:33 -0400 Subject: Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset fails To: Yunlong Song , , , CC: , , , , References: <1505060436-45299-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <150fcefc-416e-7132-752a-c37f7ad88bf3@huawei.com> Date: Tue, 12 Sep 2017 09:19:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505060436-45299-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59B73621.00C5,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d0e8976ba604504fce2128fa228b55e3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 31 On 2017/9/11 0:20, Yunlong Song wrote: > Current design will lose recovery process when check_curseg_offset is OK. > > Signed-off-by: Yunlong Song Reviewed-by: Chao Yu > --- > fsck/fsck.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fsck/fsck.c b/fsck/fsck.c > index cb341ba..56a47be 100644 > --- a/fsck/fsck.c > +++ b/fsck/fsck.c > @@ -2026,9 +2026,11 @@ int fsck_verify(struct f2fs_sb_info *sbi) > fix_hard_links(sbi); > fix_nat_entries(sbi); > rewrite_sit_area_bitmap(sbi); > - move_curseg_info(sbi, SM_I(sbi)->main_blkaddr); > - write_curseg_info(sbi); > - flush_curseg_sit_entries(sbi); > + if (check_curseg_offset(sbi)) { > + move_curseg_info(sbi, SM_I(sbi)->main_blkaddr); > + write_curseg_info(sbi); > + flush_curseg_sit_entries(sbi); > + } > fix_checkpoint(sbi); > } else if (is_set_ckpt_flags(cp, CP_FSCK_FLAG)) { > write_checkpoint(sbi); >