Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751286AbdILHim (ORCPT ); Tue, 12 Sep 2017 03:38:42 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:45015 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdILHik (ORCPT ); Tue, 12 Sep 2017 03:38:40 -0400 X-Google-Smtp-Source: ADKCNb5gBeUUpRWeERW5L1RW/7ft99NhjInWrqpeyFSuONrxus4CQgc4BTl2kUmEdjhdFUrnmBwCg+kodf6E9WNl5Ns= MIME-Version: 1.0 In-Reply-To: <20170904105322.23228-1-colin.king@canonical.com> References: <20170904105322.23228-1-colin.king@canonical.com> From: Linus Walleij Date: Tue, 12 Sep 2017 09:38:38 +0200 Message-ID: Subject: Re: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static To: Colin King Cc: Baolin Wang , "linux-gpio@vger.kernel.org" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 22 On Mon, Sep 4, 2017 at 12:53 PM, Colin King wrote: > From: Colin Ian King > > The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name > and sprd_pmx_get_function_groups are local to the source and do not > need to be in global scope, so make them static. > > Cleans up sparse warnings: > "symbol 'sprd_pmx_get_function_count' was not declared. Should it be > static?" > "symbol 'sprd_pmx_get_function_name' was not declared. Should it be > static?" > "symbol 'sprd_pmx_get_function_groups' was not declared. Should it be > static?" > > Signed-off-by: Colin Ian King Patch applied for fixes. Yours, Linus Walleij