Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264593AbTGHQFp (ORCPT ); Tue, 8 Jul 2003 12:05:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264592AbTGHQFp (ORCPT ); Tue, 8 Jul 2003 12:05:45 -0400 Received: from [128.2.206.88] ([128.2.206.88]:13483 "EHLO delft.aura.cs.cmu.edu") by vger.kernel.org with ESMTP id S264376AbTGHQFn (ORCPT ); Tue, 8 Jul 2003 12:05:43 -0400 Date: Tue, 8 Jul 2003 12:20:08 -0400 To: Trond Myklebust Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] path_lookup for 2.4.20-pre4 (ChangeSet@1.587.10.71) Message-ID: <20030708162008.GA18924@delft.aura.cs.cmu.edu> Mail-Followup-To: Trond Myklebust , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <16138.53118.777914.828030@charged.uio.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16138.53118.777914.828030@charged.uio.no> User-Agent: Mutt/1.5.4i From: Jan Harkes Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 26 One thing you might want to add to avoid revalidating all pathnames that happen to start with a dot, like '.bashrc'. Jan On Tue, Jul 08, 2003 at 04:04:46PM +0200, Trond Myklebust wrote: > diff -u --recursive --new-file linux-2.4.22-odirect/fs/namei.c linux-2.4.22-fix_cto/fs/namei.c > --- linux-2.4.22-odirect/fs/namei.c 2003-06-27 13:34:41.000000000 +0200 > +++ linux-2.4.22-fix_cto/fs/namei.c 2003-07-08 15:51:08.000000000 +0200 > @@ -732,6 +732,24 @@ > nd->last_type = LAST_DOT; > else if (this.len == 2 && this.name[1] == '.') > nd->last_type = LAST_DOTDOT; + else + goto return_base; > +return_reval: > + /* > + * We bypassed the ordinary revalidation routines. > + * We may need to check the cached dentry for staleness. > + */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/