Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdILJQG (ORCPT ); Tue, 12 Sep 2017 05:16:06 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:35585 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdILJQD (ORCPT ); Tue, 12 Sep 2017 05:16:03 -0400 X-Google-Smtp-Source: AOwi7QAyd8xpkH+Cic99rzNHZbdKa9JqYdTGFgFw7e783D+FewwrDb7WauRnmkfQrg4RQskPF0XbF2CdBB03EgqUF9w= MIME-Version: 1.0 In-Reply-To: <1504704043-8052-12-git-send-email-rf@opensource.wolfsonmicro.com> References: <1504704043-8052-1-git-send-email-rf@opensource.wolfsonmicro.com> <1504704043-8052-12-git-send-email-rf@opensource.wolfsonmicro.com> From: Linus Walleij Date: Tue, 12 Sep 2017 11:16:02 +0200 Message-ID: Subject: Re: [PATCH v5 11/17] pinctrl: madera: Add driver for Cirrus Logic Madera codecs To: Richard Fitzgerald Cc: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 32 On Wed, Sep 6, 2017 at 3:20 PM, Richard Fitzgerald wrote: > These codecs have a variable number of I/O lines each of which > is individually selectable to a wide range of possible functions. > > The functionality is slightly different from the traditional muxed > GPIO since most of the functions can be mapped to any pin (and even > the same function to multiple pins). Most pins have a dedicated > "alternate" function that is only available on that pin. The > alternate functions are usually a group of signals, though it is > not always necessary to enable the full group, depending on the > alternate function and how it is to be used. The mapping between > alternate functions and GPIO pins varies between codecs depending > on the number of alternate functions and available pins. > > Note on the Kconfig options: > The formula "default y if..." is used for PINCTRL_MADERA so that its > select options will be processed, allowing us to group selects for > pinctrl into the pinctrl Kconfig where they logically belong instead > of accumulating under the parent MFD Kconfig. > > Signed-off-by: Richard Fitzgerald > --- > No changes since V4 I think I reviewed this? Did I miss it? Anyways Reviewed-by: Linus Walleij Yours, Linus Walleij