Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbdILKWv (ORCPT ); Tue, 12 Sep 2017 06:22:51 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:31168 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdILKWu (ORCPT ); Tue, 12 Sep 2017 06:22:50 -0400 X-IronPort-AV: E=Sophos;i="5.42,382,1500933600"; d="scan'208";a="290657415" Date: Tue, 12 Sep 2017 12:22:18 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Harsha Sharma cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space In-Reply-To: <1505210936-24971-1-git-send-email-harshasharmaiitr@gmail.com> Message-ID: References: <1505210936-24971-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3013 Lines: 79 It'sa small detail, but perhaps you could fix the spelling of unnecessary (1 c and 2 s's). julia On Tue, 12 Sep 2017, Harsha Sharma wrote: > Remove space between function name and open parenthesis '(' > Remove space before ';', '++', ',' > > Signed-off-by: Harsha Sharma > --- > Change in v2: > -Merge patches 07/10 and 08/10 > > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > index eb21821..61be2b8 100644 > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > @@ -235,8 +235,8 @@ > MODULE_PARM_DESC(rtw_decrypt_phy_file, "Enable Decrypt PHY File"); > > int _netdev_open(struct net_device *pnetdev); > -int netdev_open (struct net_device *pnetdev); > -static int netdev_close (struct net_device *pnetdev); > +int netdev_open(struct net_device *pnetdev); > +static int netdev_close(struct net_device *pnetdev); > > static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev) > { > @@ -258,7 +258,7 @@ static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev) > if (registry_par->channel > 14) > registry_par->channel = 1; > > - registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense ; > + registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense; > registry_par->vcs_type = (u8)rtw_vcs_type; > registry_par->rts_thresh = (u16)rtw_rts_thresh; > registry_par->frag_thresh = (u16)rtw_frag_thresh; > @@ -607,7 +607,7 @@ u32 rtw_start_drv_threads(struct adapter *padapter) > return _status; > } > > -void rtw_stop_drv_threads (struct adapter *padapter) > +void rtw_stop_drv_threads(struct adapter *padapter) > { > RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+rtw_stop_drv_threads\n")); > > @@ -1228,7 +1228,7 @@ void rtw_dev_unload(struct adapter *padapter) > DBG_871X("stop cmdthd timeout\n"); > break; > } else { > - cnt ++; > + cnt++; > DBG_871X("cmdthd is running(%d)\n", cnt); > msleep(10); > } > @@ -1879,7 +1879,7 @@ int rtw_resume_common(struct adapter *padapter) > pwrpriv->pno_in_resume = false; > #endif > } > - DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__ , ret, > + DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__, ret, > jiffies_to_msecs(jiffies - start_time)); > > return ret; > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505210936-24971-1-git-send-email-harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >