Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbdILKYc (ORCPT ); Tue, 12 Sep 2017 06:24:32 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:59114 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751214AbdILKYa (ORCPT ); Tue, 12 Sep 2017 06:24:30 -0400 Subject: Re: [PATCH] ieee802154: fix gcc-4.9 warnings To: Arnd Bergmann , Harry Morris , linuxdev@cascoda.com, Alexander Aring Cc: Marcel Holtmann , "David S. Miller" , Markus Elfring , "Gustavo A. R. Silva" , Florian Westphal , Johannes Berg , Christophe JAILLET , Colin Ian King , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170912101636.3811626-1-arnd@arndb.de> From: Stefan Schmidt Message-ID: Date: Tue, 12 Sep 2017 12:24:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170912101636.3811626-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 37 Hello. On 09/12/2017 12:16 PM, Arnd Bergmann wrote: > All older compiler versions up to gcc-4.9 produce these > harmless warnings: > > drivers/net/ieee802154/ca8210.c: In function 'ca8210_skb_tx': > drivers/net/ieee802154/ca8210.c:1947:9: warning: missing braces around initializer [-Wmissing-braces] > > This changes the syntax to something that works on all versions > without warnings. > > Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ieee802154/ca8210.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > index 24a1eabbbc9d..e6b8ce81a6c3 100644 > --- a/drivers/net/ieee802154/ca8210.c > +++ b/drivers/net/ieee802154/ca8210.c > @@ -1944,7 +1944,7 @@ static int ca8210_skb_tx( > ) > { > int status; > - struct ieee802154_hdr header = { 0 }; > + struct ieee802154_hdr header = { }; > struct secspec secspec; > unsigned int mac_len; > Acked-by: Stefan Schmidt regards Stefan Schmidt