Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdILMKX (ORCPT ); Tue, 12 Sep 2017 08:10:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:53710 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751375AbdILMKW (ORCPT ); Tue, 12 Sep 2017 08:10:22 -0400 Date: Tue, 12 Sep 2017 14:10:16 +0200 From: Petr Mladek To: Helge Deller Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky , Andrew Morton , Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses Message-ID: <20170912121016.GF2908@pathway.suse.cz> References: <1504729681-3504-1-git-send-email-deller@gmx.de> <1504729681-3504-3-git-send-email-deller@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504729681-3504-3-git-send-email-deller@gmx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 30 On Wed 2017-09-06 22:27:49, Helge Deller wrote: > Use the %pS printk format for printing symbols from direct addresses. > In usermode-linux there is actually no difference between %pS and %pF, but for > consistency throughout the kernel fix the wrong usage here too. > > Signed-off-by: Helge Deller > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: user-mode-linux-devel@lists.sourceforge.net > --- > arch/um/kernel/sysrq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c > index 6b995e8..05585ee 100644 > --- a/arch/um/kernel/sysrq.c > +++ b/arch/um/kernel/sysrq.c > @@ -20,7 +20,7 @@ > > static void _print_addr(void *data, unsigned long address, int reliable) > { > - pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ", > + pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ", > (void *)address); This seems to be used to print addresses from the stack. IMHO, we should use %pB here. Best Regards, Petr