Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbdILMXG (ORCPT ); Tue, 12 Sep 2017 08:23:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:54670 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751379AbdILMXE (ORCPT ); Tue, 12 Sep 2017 08:23:04 -0400 Date: Tue, 12 Sep 2017 14:23:02 +0200 From: Petr Mladek To: Helge Deller Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky , Andrew Morton Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Message-ID: <20170912122302.GG2908@pathway.suse.cz> References: <1504729681-3504-1-git-send-email-deller@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504729681-3504-1-git-send-email-deller@gmx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 39 On Wed 2017-09-06 22:27:47, Helge Deller wrote: > This patch series fixes the wrong usages of the %pF and %pS printk format > specifiers throughout the kernel code. > > Both specifiers have the same result on most architectures. But on ia64, ppc64 > and parisc64 architectures the %pF specifier does an extra conversion because > there function pointers are actually function descriptors. > > Helge > > Helge Deller (14): > arm: Use %pS printk format for symbols from direct addresses > um: Use %pS printk format for symbols from direct addresses IMHO, we should use %pB in this patch. > x86: Use %pS printk format for symbols from direct addresses > ti_sci: Use %pS printk format for direct addresses > i915: Use %pS printk format for direct addresses > md/bcache: Use %pS printk format for direct addresses > power/avs: Use %pS printk format for direct addresses > fs/f2fs: Use %pS printk format for direct addresses > fs/pstore: Use %pS printk format for direct addresses > fs/xfs: Use %pS printk format for direct addresses > smp: Use %pF printk format specifier for function pointers > mm/memblock: Use %pS printk format for direct addresses > netfilter/ipvs: Use %pS printk format for direct addresses > sound/core: Use %pS printk format for direct addresses All other patches look fine. For the entire patchset, except for the "um: " patch, feel free to use: Reviewed-by: Petr Mladek Let me known if this is enough or if I should answer each patch individually. Best Regards, Petr