Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdILOOo (ORCPT ); Tue, 12 Sep 2017 10:14:44 -0400 Received: from mga05.intel.com ([192.55.52.43]:8291 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdILOOn (ORCPT ); Tue, 12 Sep 2017 10:14:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,383,1500966000"; d="scan'208";a="1013600689" Message-ID: <1505225681.1331.1.camel@tzanussi-mobl.amr.corp.intel.com> Subject: Re: [PATCH v2 00/40] tracing: Inter-event (e.g. latency) support From: Tom Zanussi To: Masami Hiramatsu Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com, mathieu.desnoyers@efficios.com, baohong.liu@intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Tue, 12 Sep 2017 09:14:41 -0500 In-Reply-To: <20170912105003.860ff7b4cd9bfd3e4d1796b1@kernel.org> References: <20170912105003.860ff7b4cd9bfd3e4d1796b1@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 53 Hi Masami, On Tue, 2017-09-12 at 10:50 +0900, Masami Hiramatsu wrote: > On Tue, 5 Sep 2017 16:57:12 -0500 > Tom Zanussi wrote: > > > Hi, > > > > This is V2 of the inter-event tracing patchset. > > > > There are too many changes to list in detail, most of them directly > > addressing input from V1, but here are the major changes from V1 > > (thanks to everyone who reviewed V1 and thanks to both Vedang Patel > > and Baohong Liu for their contributions and included patches): > [..] > > > > > Documentation/trace/events.txt | 431 ++++ > > include/linux/ring_buffer.h | 17 +- > > include/linux/trace_events.h | 24 +- > > include/linux/tracepoint-defs.h | 1 + > > kernel/trace/ring_buffer.c | 126 +- > > kernel/trace/trace.c | 205 +- > > kernel/trace/trace.h | 25 +- > > kernel/trace/trace_events.c | 51 +- > > kernel/trace/trace_events_hist.c | 4472 +++++++++++++++++++++++++++++++---- > > kernel/trace/trace_events_trigger.c | 53 +- > > kernel/trace/trace_kprobe.c | 18 +- > > kernel/trace/trace_probe.c | 86 - > > kernel/trace/trace_probe.h | 7 - > > kernel/trace/trace_uprobe.c | 2 +- > > kernel/trace/tracing_map.c | 229 +- > > kernel/trace/tracing_map.h | 20 +- > > kernel/tracepoint.c | 18 +- > > 17 files changed, 5073 insertions(+), 712 deletions(-) > > There seems no Makefile and Kconfig changes. Would this mean > we just need CONFIG_HIST_TRIGGERS=y to enable it? > Yes - I didn't see a need for a separate config for this. > I think you'd better update the HIST_TRIGGER's description > so that user can notice which should be enabled for inter-event > tracing. > Good point, will do. Thanks, Tom