DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8AB5A5D685
Message-ID: <1505226117.31639.24.camel@redhat.com>
Subject: Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming
From: Gerd Hoffmann <kraxel@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Emil Velikov <emil.l.velikov@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
        Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
        "open list:VIRTIO GPU DRIVER" 
        <virtualization@lists.linux-foundation.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        kernel-janitors@vger.kernel.org,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Date: Tue, 12 Sep 2017 16:21:57 +0200
In-Reply-To: <20170912140921.maegwq32x5a6jyql@mwanda>
References: <20170912094548.30603-1-colin.king@canonical.com>
         <CACvgo53vbGbvejkEnQuuB-ZuVfbzvSmAsx3Ovj-wMWMQE8ihXw@mail.gmail.com>
         <20170912140921.maegwq32x5a6jyql@mwanda>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 516
Lines: 17

On Tue, 2017-09-12 at 17:09 +0300, Dan Carpenter wrote:
> On Tue, Sep 12, 2017 at 03:02:04PM +0100, Emil Velikov wrote:
> > That said, I'm not sure how useful the information is - perhaps
> > it's
> > better to drop it all together?
> 
> Or a WARN_ONCE().

It's userspace calling into the driver with invalid parameters.

IMO we should never WARN_ONCE() on something userspace can trigger.

I'd suggest to just drop the message altogether, simply throwing EINVAL
at userspace is perfectly fine IMHO.

cheers,
  Gerd