Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbdILOWB (ORCPT ); Tue, 12 Sep 2017 10:22:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59330 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbdILOV6 (ORCPT ); Tue, 12 Sep 2017 10:21:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8AB5A5D685 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com Message-ID: <1505226117.31639.24.camel@redhat.com> Subject: Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming From: Gerd Hoffmann To: Dan Carpenter , Emil Velikov Cc: Colin King , Dave Airlie , David Airlie , "open list:VIRTIO GPU DRIVER" , ML dri-devel , kernel-janitors@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" Date: Tue, 12 Sep 2017 16:21:57 +0200 In-Reply-To: <20170912140921.maegwq32x5a6jyql@mwanda> References: <20170912094548.30603-1-colin.king@canonical.com> <20170912140921.maegwq32x5a6jyql@mwanda> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 12 Sep 2017 14:21:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 516 Lines: 17 On Tue, 2017-09-12 at 17:09 +0300, Dan Carpenter wrote: > On Tue, Sep 12, 2017 at 03:02:04PM +0100, Emil Velikov wrote: > > That said, I'm not sure how useful the information is - perhaps > > it's > > better to drop it all together? > > Or a WARN_ONCE(). It's userspace calling into the driver with invalid parameters. IMO we should never WARN_ONCE() on something userspace can trigger. I'd suggest to just drop the message altogether, simply throwing EINVAL at userspace is perfectly fine IMHO. cheers, Gerd