Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbdILOez (ORCPT ); Tue, 12 Sep 2017 10:34:55 -0400 Received: from muru.com ([72.249.23.125]:40456 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbdILOeu (ORCPT ); Tue, 12 Sep 2017 10:34:50 -0400 Date: Tue, 12 Sep 2017 07:34:46 -0700 From: Tony Lindgren To: "Derald D. Woods" Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] ARM: dts: omap3: Fix Sharp LS037V7DW01 compatible string and envdd supply Message-ID: <20170912143444.GR5024@atomide.com> References: <20170903003816.5536-1-woods.technical@gmail.com> <20170912034659.13184-1-woods.technical@gmail.com> <20170912034659.13184-4-woods.technical@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912034659.13184-4-woods.technical@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 30 * Derald D. Woods [170911 20:48]: > The Sharp panel driver and regulator are now selected properly. This > commit eliminates a dummy regulator assignment. > > Signed-off-by: Derald D. Woods > > --- > arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi b/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi > index 157345bb8e79..15f73e5adfdf 100644 > --- a/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi > +++ b/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi > @@ -26,9 +26,10 @@ > }; > > lcd0: display { > - compatible = "sharp,ls037v7dw01"; > + compatible = "omapdss,sharp,ls037v7dw01"; Is this change needed? I think the driver automatically matches even with the "omapdss" part missing? If it's needed, can you please update the description for why it's needed. Regards, Tony