Subject: Re: [PATCH 3/3] KVM: SVM: Add irqchip_split() checks before enabling
 AVIC
To: Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1504669169-4919-1-git-send-email-suravee.suthikulpanit@amd.com>
 <1504669169-4919-4-git-send-email-suravee.suthikulpanit@amd.com>
 <20170908155324.GB14748@flask> <9475950b-566f-9425-5de9-9e6677e41043@amd.com>
 <20170912131727.GA24326@flask>
 <1ab4bded-a6a6-0a10-d3ea-96b7c38b93f0@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, joro@8bytes.org
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <3d9db6dd-3598-7cbe-fb70-46a36110da3b@amd.com>
Date: Tue, 12 Sep 2017 08:07:22 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1ab4bded-a6a6-0a10-d3ea-96b7c38b93f0@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2017 15:07:38.2764 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1738
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1080
Lines: 28


On 9/12/17 07:22, Paolo Bonzini wrote:
> On 12/09/2017 15:17, Radim Krčmář wrote:
>>>> Yeah, hacking TMR to get the VM exit could result in future bugs.
>>>> We have to push split irqchip as the deafult in userspaces with this
>>>> change.
>>> Actually, I'm not quite sure about the advantages/disadvantages with split
>>> irqchip, and how it would affect other cases, and why it was not used as
>>> default currently.
>> The main advantage of split irqchip is that we're moving code out of the
>> kernel, and QEMU's irqchip currently has more features too.
>>
>> I think it is not the default as the support for split irqchip is recent
>> (v4.3) and has lower performance, so it is only used in cases that need
>> the extra features.
>
> One other difference is that in-kernel PIT is not supported with
> split-irqchip, and the QEMU PIT lacks support for reinjecting lost
> ticks.  But this should only be needed for very old guests at this point.
>
> Paolo
>

Thanks. I'll look into patch for changing the default in QEMU and follow up with 
that separately then.

Suravee