Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbdILPHv (ORCPT ); Tue, 12 Sep 2017 11:07:51 -0400 Received: from mail-co1nam03on0050.outbound.protection.outlook.com ([104.47.40.50]:2016 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751404AbdILPHn (ORCPT ); Tue, 12 Sep 2017 11:07:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH 3/3] KVM: SVM: Add irqchip_split() checks before enabling AVIC To: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1504669169-4919-1-git-send-email-suravee.suthikulpanit@amd.com> <1504669169-4919-4-git-send-email-suravee.suthikulpanit@amd.com> <20170908155324.GB14748@flask> <9475950b-566f-9425-5de9-9e6677e41043@amd.com> <20170912131727.GA24326@flask> <1ab4bded-a6a6-0a10-d3ea-96b7c38b93f0@redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, joro@8bytes.org From: Suravee Suthikulpanit Message-ID: <3d9db6dd-3598-7cbe-fb70-46a36110da3b@amd.com> Date: Tue, 12 Sep 2017 08:07:22 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1ab4bded-a6a6-0a10-d3ea-96b7c38b93f0@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [104.34.156.192] X-ClientProxiedBy: PS1PR0601CA0102.apcprd06.prod.outlook.com (10.170.176.156) To DM5PR12MB1738.namprd12.prod.outlook.com (10.175.89.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c368884b-e706-4f05-cd70-08d4f9f00325 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR12MB1738; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1738;3:BqUbfXFaoTwtvTVMMjtY5edJiqb2tBQN32guL73mzJqL/PuCh2U5wBEYfNvkpyPRhKTsXSxOljU7jjB15DjOVeVE1x7pH1pb4SeZ3AiF++gqQlsYdYpHgdk6cGaIRo1Cryofz11eQJp5uP/5lmeTdMlskYELA3jPkw03sBH3Ny1jSEr6PcGAqTJpsjPcgWkigDYFFM4gZj1CGV5j4pNgZkiLIQKvu92mhrDaaSSTa4UjAm85cTZB5NgQx8cGoH8l;25:GfF+cZQzZXBwiH7zD9EtOsIN80tmvpncJDC6QTXDAb5Ey3i2GP5Uc6MqW/1AdKZDvFPVrsYhwJ/QWEZuwBv9mEaPZqkDWdTUDE1mkxr2KMcdjpwtpKsOFw/2WF4vX+f1NfQLzt5VMkyNwNJT9ePuEgZ7nI6MwMRafLybARjAKLcWFtvfTTUgT0qOsvSc4MD2gL20o9InbEhHWR29cKLdu/50uXHH4WE8eW1uTULdKP+KzR0G3e11URCSD3qKyiNUnWY77Li+b7iEoAFivNjdefJKeHQp3wwbcmd+am6nEX+rLXlekqK8ckHKNHydl/uj0mSlk4SGkL9LZ9KCYzWQZA==;31:gdeZ3YPqSnymWZa0El2dStfw8IJRtLembr2eoo/prSYgvCNUkV3WVBGKCY6fo4olduP0dnpw/hlwnVCwKpUOSjS0BZgI/0ggiapD0WTxvTRjnGwqHNwDkh8XG0svnyhfkGdF+LWdKQQpusIIHyHUwlISH7gwrAVKiLqNjik7ZcB9EcD8cmbhmXdMKj23HEypcHY5JY+J07Vs+NYFgyQqjgtE7dzt4zN96mQVMhm+uLY= X-MS-TrafficTypeDiagnostic: DM5PR12MB1738: X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1738;20:17T/pyJspCeVfteGkvsq5paPapifIamh0OI28ddZ6PdlftHa3QGd6LBCljRGz3kQUoI1rJEKNMvovLcUHAjwBQA9dsKhkTDgUOlUUvXGmNYaEODqdd5EHE+6Q68vX900VtjV9hDzJIzDlIGzgLB6+o6/SVSGRzwZFKgKUcYkpx/VRjQG4BR2GmBMINIqLRq9CiYiglIprSkJtNizFE1CuycYdhcjx9T/FoLpz/UXOHi4dob/VxkdeuLYwwWfaRHoEvjrM8J8Do0Y67ZDPHCpo3L3lptY9HqR67nn0muETSQ8AwBhHMQY+gDSllNWQUavibFaQJJTllvVQP7zjLym+uIybQrhjfx+jYKvdyi1iGjqTlTS+ZJdU1cki9C2UvfkPeDXuOisBrt+tg4J13AO6muemWBc9cYZXcJV+3kpplFlfUrtFqFMtFlxbTgx9esiFaeDgXi6Jr4028AQ4DhjKnWvoujyAAOWHUSWfPpkK/qfoWx3FF0EJiuWn18wLMOO;4:G1ghPDI3T/z75xCkfBOevVitvFUTThhsGPc2OioCtGb3Gt6JuCCeXii54QFciTmtC45GuUh92GxhCtlocq6D1moLP3uOeIdF+2FgIF1O6FIMuPSUdFnlwlOw4ny2i9voJtSeoEn+ExIiH3LTgbPIn0B270eIiyI2RXJOGHYlHH9UDJ5OD2TLdpbG2ZxuvcayuE9IairsdN52rjB27SXC9v9LBz7yoGJkyPzmp2NaDo6SSlsElwfFou4JlwzYGacO X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR12MB1738;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR12MB1738; X-Forefront-PRVS: 042857DBB5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(24454002)(189002)(199003)(66066001)(83506001)(50986999)(50466002)(305945005)(7736002)(42186005)(5660300001)(25786009)(65826007)(76176999)(47776003)(65956001)(81156014)(65806001)(6666003)(8676002)(6116002)(81166006)(2950100002)(64126003)(72206003)(229853002)(23676002)(4001350100001)(3846002)(97736004)(6486002)(105586002)(8936002)(33646002)(2870700001)(189998001)(2906002)(478600001)(93886005)(31696002)(106356001)(6246003)(31686004)(54356999)(101416001)(53936002)(4326008)(68736007)(6512007)(6506006)(86362001)(53546010)(36756003)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1738;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNzM4OzIzOjRob0hRMnN1aXphZnR1aXd4TmNxUGdnbmE5?= =?utf-8?B?Zm9OZ29hVXBnQzFXN1MxMUlBU3pSYmJEaGlYNjhVN1NzV2pJbk1HU3phY0Nm?= =?utf-8?B?anMrdEpDeG1pSXVEK3dGazFCZG1IcGx2dzF0MW82UUdwNXdsZVEza0lSV1NL?= =?utf-8?B?VHlhaWxVZWRIKzZhWW5pQ0w1QU5OZXFsb2lZWEFramxYVFFjVWFaLzRyTnE5?= =?utf-8?B?NDFTR3JlUEhGRW9NYlRieUtwVFEzVExucXZoN2xSdHJzN2kyRDRVeVVqbFV5?= =?utf-8?B?SzJqWXpydXV6UDZiTE9IWVJSNmxrcTRLUlVKRHR1WCtCS1pFejBudjdDR1kz?= =?utf-8?B?QUpyUHQrcFZmb2Q5aFQ2cWszbHc3V0RLQnJJWmY5ZGNaUW1JK3MrR0ZQZWw1?= =?utf-8?B?R3oxSWV3YlpTaTF1RitoZkU3UElwRG9DTmcwZzgxQVVXYWZQcnE2WEgxS1Y4?= =?utf-8?B?NTJKdC9PRnQxdFBlejErL3BCcGtFQzZ1VUVwVE1xRUhvdFNkenVTdjBWckJR?= =?utf-8?B?dzJaemZkZk0waytCSHgrRW1QdEIrY0wxY3hHSlVIUUVOZ1dJRTNiMVlSSTYy?= =?utf-8?B?Z01jUjdoZTdFeStBYzdNaDNRL0VOU1RlYUZIY1JvQkNHNXp3NDhvbEhCSWww?= =?utf-8?B?UUk0MUhPWVhBS2pnWEVBWVd1d3FLMmtkNytESUJ6NFBBek1sYVFCSEFHOUdX?= =?utf-8?B?cmtNWFJUbG5oTFR2MzRFeEp1VUVmMmRpbXB1VmlvVUpwaWZ4VjlDYjBBcVhF?= =?utf-8?B?NlpSWk9pVWZIMmozaW9Ic1QzZjNJbW44Q3ZvOGxQUDJXNU9MamNNSEt4Yk1Y?= =?utf-8?B?NUFSaUVPRTJPOW5pbTdaOFVXaEFkTWhZMTBMcXc5TW8zU25Yd1d2RThsU2N4?= =?utf-8?B?WnBWZXpJMHdaWlBNMXFzaDltbytuYjFKbW52Z1laalA5dTJUY1RYV2ZPQ1gx?= =?utf-8?B?RCtia1diTEtUYi9LVkdCV3dWOGU2NzRzdWl5MUpleTlGb3ZrLytVWGhvejFz?= =?utf-8?B?aU5PWVllSDlCdHgzRzVCUW5CLzJlQ3VyUDl3aFRXYm1nN2c2LzluZUhpSUt0?= =?utf-8?B?MGxDdFJ5WEVmN0QxQUlGMXlxNXJTRU12a082NUlaWVRMZjVObnZSQldheS8v?= =?utf-8?B?NUhRWnlITk9LNU8rNVNiQkphT1NrMjBtTTlnMmhQeGVZOTV1b0ZNMG5JaDV6?= =?utf-8?B?a1Q2dzg4NkJyR1gyampIR0U1dmd5ZjlseXZwYmpGNDBERGVaL2p0ZWdMVDI5?= =?utf-8?B?VHpIR0U4WUdRMmxhb25wT3ZoRlpnamg2UGp3SHVuazVIWlVNdE1JaTdHSG1X?= =?utf-8?B?eGJvT0x3K2JZbGVRTXhzYjFQTmVDVzVGOUJacHZWUXRBQVBaNVhIR01vU0hy?= =?utf-8?B?SVhsVHdlMy82eFhUOGczeXJIUTVyVWQ5ZFpGZWhHNy9qOGFuaWtnSUJiRnQy?= =?utf-8?B?WHRyd1g4c2lFRTZTajJkbEVvcTA4dGMwMG1JNVAraWZYWDEzNDFlRmpqZWJn?= =?utf-8?B?YTUxUVB5TlMrMUprWFdTbnBhRmhPdTBqSUtySlRhTTJUQXNzU1JkYWUzM3R3?= =?utf-8?B?Sjc2bkpyMWsxUDRmZnRlNEZBUVlzd29oejQ4ZDZ4M1hoN0VnQXJtRFJJNTlm?= =?utf-8?B?WkFxR2gxQnp3NE4yTEhQZy9xQWFOKzB3SXlsZ3VMM2dwVnlBdVNST1VJRUh6?= =?utf-8?B?dzFGNk1YWklCNWdZcFMzWEdESERSVUlwRzh6OGhRQ1ZrYUVPTk4rNm84ZGdG?= =?utf-8?B?dGVydmxEeC9CaldqTUsxajBLcjFuUDdrNEFCNEhiMXgva0V0dndRQm4wUGR1?= =?utf-8?Q?uZlF26c06JwSl?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1738;6:RtKQGiaN1tSj4lz8Lm8sPsPBH1IXx1Y60Or3NUb87NLqYQI7hWb5kPv0+JeCQnvbcQfhGIVDsE6pr9WzgGMWK4hMmfIU5W2igLs8Sd7Fyx84kAMkK3bh0Cc9fRCloSHg48X8b3WcN3Sm0wPVEKHEbh9WuQrKvBK/wPlkZ6dOJcnYitKyozPGnH20HsgVwr35h1KPGyutpqdAcsbK23VmlWuhpeyulQXjpE2xnbnyNTK8rTaTCZvhweG7cgCKpJ3pAYUYpl7hrJ7KV3Wj/2Ib/m/xPaaLPSyuhbP8b5sXyaszcPv/ANfZCywd8E9xOWRbiWGVK5Q0TY9DlUpJlEqYMw==;5:a1OBpFR62Vb1COxk6ACZGQlUJ6qv+eWmM6pL/Xdp/fGNYTdOHIJzqs51mPOU5dq00jpSOQn+iN8btTZb3n9At2IHUEw1FkJV4gCk6hN5MOWoon06HLv8kkpBwFlqpAMdzyvaM7H1B57GFv9acuULVQ==;24:5hXA8rRCe/TT06r5EfieLwAJ7F3CMcl05JbBrYu/8X/luFkj//DBr8XYgYzj90IzAeN76HJfJAYY1bMLrMGGY7URQUvZHfX0E24e0gGUwx0=;7:4rmUQi1RPyOEqh1EalAivk2c9APLSXcza8Wk81D2h5zBThuEn3bT17PtOVIp6nKcsv+LDtBoh8hMGPIr2zb8QweXylNQrkuQIE24nxz1JCA0Ii5iogts88cWGc5WJrbtE4iJtZ0DLN2QyRGFW72EYCKW3YOwJkU0zfQP+dFuwsr0DaLAZ8oq/zwWa/faYsFPGmnNP56v7te9lPMYWUz9dQQkbxzxr7yOkRrBW85gPmo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1738;20:G0Z1O2GaL1Ly65MZ4SAGwPZI1DFVAqJ+dkCui5eFgfDkSAuOOATNyotpIq9shOyZkqADRHt0g4GDkNoAfCkHW+AlFcUbLoBfFb2iyYb/RXM1RUmO9gLJL49SHAFjYqTSfFjl5HAxJK9SrO1g3kClMA2WCbfohKDHhLVhm8h6Dd8IuOrPlpoM/1viGherxw46ckq0nJytuu5Bpcif6/c+ag0/RJpmpVZV1LJqq5xq0ecZtZfcEfGj5u/KQj++8vmz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2017 15:07:38.2764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1738 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 28 On 9/12/17 07:22, Paolo Bonzini wrote: > On 12/09/2017 15:17, Radim Krčmář wrote: >>>> Yeah, hacking TMR to get the VM exit could result in future bugs. >>>> We have to push split irqchip as the deafult in userspaces with this >>>> change. >>> Actually, I'm not quite sure about the advantages/disadvantages with split >>> irqchip, and how it would affect other cases, and why it was not used as >>> default currently. >> The main advantage of split irqchip is that we're moving code out of the >> kernel, and QEMU's irqchip currently has more features too. >> >> I think it is not the default as the support for split irqchip is recent >> (v4.3) and has lower performance, so it is only used in cases that need >> the extra features. > > One other difference is that in-kernel PIT is not supported with > split-irqchip, and the QEMU PIT lacks support for reinjecting lost > ticks. But this should only be needed for very old guests at this point. > > Paolo > Thanks. I'll look into patch for changing the default in QEMU and follow up with that separately then. Suravee