Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbdILPL6 (ORCPT ); Tue, 12 Sep 2017 11:11:58 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:50907 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbdILPLu (ORCPT ); Tue, 12 Sep 2017 11:11:50 -0400 X-IronPort-AV: E=Sophos;i="5.42,383,1500912000"; d="scan'208";a="50251528" From: Bart Van Assche To: "jejb@linux.vnet.ibm.com" , "colin.king@canonical.com" , "linux-scsi@vger.kernel.org" , "jpinto@synopsys.com" , "martin.petersen@oracle.com" , "vinholikatti@gmail.com" CC: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size Thread-Topic: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size Thread-Index: AQHTK7sDvck2TEQnak+nieADXfcN7KKxWzCA Date: Tue, 12 Sep 2017 15:10:54 +0000 Message-ID: <1505229053.2537.0.camel@wdc.com> References: <20170912113228.1389-1-colin.king@canonical.com> In-Reply-To: <20170912113228.1389-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1520;20:HzvfMptn1QpYBcEPqgNAI3zSBqCwOkiENTtFBhIYpTOq4/m/dTdBnVw1A4SchUfKdOzP9B+fCQKfwwMAtjN141CncOZJVblI/K9JwmZWYtV2fPz7kLR2L0VObMW6Hbg49SKBwbbUFQ6CbFd0AfQo2dZAw6BeEEoZq5FLObJ8mEs= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 92c03cdb-0620-413f-5916-08d4f9f076fb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1520; x-ms-traffictypediagnostic: CY1PR0401MB1520: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:(198206253151910); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1520;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1520; x-forefront-prvs: 042857DBB5 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(199003)(24454002)(377424004)(189002)(8676002)(6246003)(4326008)(97736004)(81166006)(76176999)(230783001)(305945005)(77096006)(72206003)(68736007)(39060400002)(6486002)(7736002)(6506006)(81156014)(3846002)(5660300001)(189998001)(86362001)(575784001)(6436002)(316002)(2900100001)(50986999)(3280700002)(54356999)(3660700001)(66066001)(25786009)(102836003)(6116002)(478600001)(6512007)(54906002)(14454004)(53936002)(101416001)(36756003)(2950100002)(99286003)(103116003)(105586002)(33646002)(106356001)(229853002)(8936002)(2201001)(2906002)(2501003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1520;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5734B7B391F6EC4992B6A69A1AAB5A3D@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2017 15:10:54.8483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1520 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8CFGBuF002973 Content-Length: 710 Lines: 20 On Tue, 2017-09-12 at 12:32 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them > static. Makes the object code smaller by over 740 bytes. > > Before: > text data bss dec hex filename > 3840 208 0 4048 fd0 drivers/scsi/ufs/tc-dwc-g210.o > > After: > text data bss dec hex filename > 2679 624 0 3303 ce7 drivers/scsi/ufs/tc-dwc-g210.o > > Signed-off-by: Colin Ian King Please CC the most active contributors of a driver when submitting a driver patch. Anyway: Reviewed-by: Bart Van Assche