Date: Tue, 8 Jul 2003 10:59:12 -0700
From: Andrew Morton <akpm@osdl.org>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.net, davem@redhat.com,
       jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, rddunlap@osdl.org
Subject: Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting
Message-Id: <20030708105912.57015026.akpm@osdl.org>
In-Reply-To: <3F0AFFE6.E85FF283@us.ibm.com>
References: <3F0AFFE6.E85FF283@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 26

Jim Keniston <jkenisto@us.ibm.com> wrote:
>
> The enclosed patches provide a mechanism for reporting error events
> to user-mode applications via netlink.

Seems sane to me.

It needs to handle %z as well as %Z.

The layout of `struct kern_log_entry' may be problematic.  Think of the
situation where a 64-bit kernel constructs one of these and sends it up to
32-bit userspace.  Will the structure layout be the same under the 32-bit
compiler as under the 64-bit one?

How do you actually intend to use this?  Will it be by adding new
evt_printf() calls to particular drivers, or replacing existing printk's or
both?

Would it make sense for evt_printf() to fall back to printk() if nobody is
listening to the log stream?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/