Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbdILQDO (ORCPT ); Tue, 12 Sep 2017 12:03:14 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36705 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbdILQDL (ORCPT ); Tue, 12 Sep 2017 12:03:11 -0400 Subject: Re: [PATCH 3/4] xen: add grant interface version dependent constants to gnttab_ops To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170908144849.2958-1-jgross@suse.com> <20170908144849.2958-4-jgross@suse.com> From: Boris Ostrovsky Message-ID: <3f1300e3-dd09-f064-13a4-7509a16b52ce@oracle.com> Date: Tue, 12 Sep 2017 12:02:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170908144849.2958-4-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 459 Lines: 16 On 09/08/2017 10:48 AM, Juergen Gross wrote: > Instead of having multiple variables with constants like > grant_table_version or grefs_per_grant_frame add those to struct > gnttab_ops and access them just via the gnttab_interface pointer. > > Signed-off-by: Juergen Gross One possible suggestion --- define gnttab_sframes() inline and get rid of RPP/SPP. But either way: Reviewed-by: Boris Ostrovsky -boris