Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbdILQUk (ORCPT ); Tue, 12 Sep 2017 12:20:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40124 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdILQUh (ORCPT ); Tue, 12 Sep 2017 12:20:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 88B37C0587DD Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Tue, 12 Sep 2017 11:20:34 -0500 From: Josh Poimboeuf To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Jiri Kosina , Miroslav Benes , Petr Mladek Subject: Re: [PATCH v6] livepatch: introduce shadow variable API Message-ID: <20170912162034.lmpkjjefg3ft4m7r@treble> References: <1504211861-19899-1-git-send-email-joe.lawrence@redhat.com> <1504211861-19899-2-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1504211861-19899-2-git-send-email-joe.lawrence@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 12 Sep 2017 16:20:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 24 On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote: > +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data, > + size_t size, gfp_t gfp_flags, bool warn_on_exist) > +{ > + struct klp_shadow *new_shadow; > + void *shadow_data; > + unsigned long flags; > + > + /* Check if the shadow variable if already exists */ Grammar fix: either s/if the shadow variable// or s/if // Otherwise: Acked-by: Josh Poimboeuf -- Josh