Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdILQ3S (ORCPT ); Tue, 12 Sep 2017 12:29:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:47912 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751054AbdILQ3Q (ORCPT ); Tue, 12 Sep 2017 12:29:16 -0400 Date: Tue, 12 Sep 2017 18:29:04 +0200 From: Borislav Petkov To: Brijesh Singh Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?utf-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky , Herbert Xu , "David S . Miller" , Gary Hook , linux-crypto@vger.kernel.org Subject: Re: [RFC Part2 PATCH v3 03/26] crypto: ccp: Add Secure Encrypted Virtualization (SEV) device support Message-ID: <20170912162904.32qkgjx7ry2id6c3@pd.tnic> References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-4-brijesh.singh@amd.com> <20170912140249.f26w5xedbrqu52i4@pd.tnic> <855be17c-382e-4e7d-7300-ca19cc50c625@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <855be17c-382e-4e7d-7300-ca19cc50c625@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 19 On Tue, Sep 12, 2017 at 10:32:13AM -0500, Brijesh Singh wrote: > The debug statement is very helpful during development, it gives me the full > view of what command we send to PSP, data dump of command buffer before and > after the request completion. e.g when dyndbg is enabled the output looks like > this: I'm sure it is all very helpful but you have a bunch of code which is always built-in and useful only to developers. Which means it could be behind #ifdef DEBUG at least and disabled on production systems. You don't have to do it immediately but once the stuff goes up and everything stabilizes, you could ifdef it out... Something to think about later, I'd say. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --