Subject: Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming
To: Colin King <colin.king@canonical.com>,
        VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Sinclair Yeh <syeh@vmware.com>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20170912173530.14132-1-colin.king@canonical.com>
From: Thomas Hellstrom <thellstrom@vmware.com>
Message-ID: <211c7afe-c778-cf39-760a-05bc3a62e5db@vmware.com>
Date: Tue, 12 Sep 2017 19:42:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170912173530.14132-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2017 17:42:08.2502 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB756
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1504
Lines: 43

Hi, Colin,

On 09/12/2017 07:35 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mmap'ing the device multiple times will spam the kernel log with the
> DRM_ERROR message about illegal mmap'ing the old fifo space.
How are you hitting this? Multiple mappings should be fine as long as 
mapping offsets are correct,
so hitting this message should indicate that the user-space app is doing 
something seriously wrong, and
having it present in the log should probably help more than it hurts.

/Thomas


> Since
> the mmap'ing will fail with an -EINVAL there is no need to emit this
> message, so just remove it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> index e771091d2cd3..1e633c602fb1 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> @@ -33,10 +33,8 @@ int vmw_mmap(struct file *filp, struct vm_area_struct *vma)
>   	struct drm_file *file_priv;
>   	struct vmw_private *dev_priv;
>   
> -	if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET)) {
> -		DRM_ERROR("Illegal attempt to mmap old fifo space.\n");
> +	if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET))
>   		return -EINVAL;
> -	}
>   
>   	file_priv = filp->private_data;
>   	dev_priv = vmw_priv(file_priv->minor->dev);