Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdILU2V (ORCPT ); Tue, 12 Sep 2017 16:28:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:42876 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750742AbdILU2S (ORCPT ); Tue, 12 Sep 2017 16:28:18 -0400 Date: Tue, 12 Sep 2017 22:28:11 +0200 From: Borislav Petkov To: Brijesh Singh Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?utf-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky Subject: Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest Message-ID: <20170912202811.ykty35bx2tvahe5s@pd.tnic> References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-6-brijesh.singh@amd.com> <20170912200416.ygcsqvznkkp2gd7r@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 17 On Tue, Sep 12, 2017 at 03:24:05PM -0500, Brijesh Singh wrote: > > If anything, this comment should explain what that variable is. > > Basically the comment you have in sev_hardware_setup() now. > > > > Will add more comments. I didn't mean that - I meant that /* Secure Encrypted Virtualization */ as a comment doesn't fit over the variable max_sev_asid. If anything, it should explain the variable or not be there at all. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --