Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516AbdILUaz (ORCPT ); Tue, 12 Sep 2017 16:30:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdILUay (ORCPT ); Tue, 12 Sep 2017 16:30:54 -0400 Date: Tue, 12 Sep 2017 13:30:52 -0700 From: Greg KH To: ArminSchoenlieb Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: irda: net: fix coding style issues in irqueue.h Message-ID: <20170912203052.GA14353@kroah.com> References: <20170911203705.10415-1-armetallica@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170911203705.10415-1-armetallica@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 40 On Mon, Sep 11, 2017 at 10:37:05PM +0200, ArminSchoenlieb wrote: > From: Armin Schoenlieb > > This is a patch to the irqueue.h file that fixes up pointer style errors and > trailing whitespace errors, found by the checkpatch.pl tool > > Signed-off-by: Armin Schoenlieb > --- > drivers/staging/irda/include/net/irda/irqueue.h | 46 ++++++++++++------------- > 1 file changed, 23 insertions(+), 23 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot