Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbdILWLD (ORCPT ); Tue, 12 Sep 2017 18:11:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbdILWLC (ORCPT ); Tue, 12 Sep 2017 18:11:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 109B381DED Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=joe.lawrence@redhat.com Subject: Re: [PATCH v6] livepatch: introduce shadow variable API To: Josh Poimboeuf Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Jiri Kosina , Miroslav Benes , Petr Mladek References: <1504211861-19899-1-git-send-email-joe.lawrence@redhat.com> <1504211861-19899-2-git-send-email-joe.lawrence@redhat.com> <20170912162034.lmpkjjefg3ft4m7r@treble> From: Joe Lawrence Organization: Red Hat Message-ID: Date: Tue, 12 Sep 2017 18:11:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170912162034.lmpkjjefg3ft4m7r@treble> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 12 Sep 2017 22:11:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 30 On 09/12/2017 12:20 PM, Josh Poimboeuf wrote: > On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote: >> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data, >> + size_t size, gfp_t gfp_flags, bool warn_on_exist) >> +{ >> + struct klp_shadow *new_shadow; >> + void *shadow_data; >> + unsigned long flags; >> + >> + /* Check if the shadow variable if already exists */ > > Grammar fix: either > > s/if the shadow variable// > > or > > s/if // > > Otherwise: > > Acked-by: Josh Poimboeuf > If this is the only outstanding nit, can this be fixed up on merge or does it need a new patch spin? Thanks, -- Joe