Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516AbdILWPm (ORCPT ); Tue, 12 Sep 2017 18:15:42 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38567 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbdILWPj (ORCPT ); Tue, 12 Sep 2017 18:15:39 -0400 X-Google-Smtp-Source: ADKCNb5o06P0ZYOMRxc3xJiI8Y1kbiWvQ7nr+3+zL2YsGJGdve7YVMgiQWbTDjUWH0LR52sVzeqf8Q== Date: Wed, 13 Sep 2017 07:15:35 +0900 From: Stafford Horne To: Pavel Machek Cc: LKML , Openrisc , Stefan Kristiansson , Rob Herring , Mark Rutland , Jonas Bonn , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 10/13] openrisc: add simple_smp dts and defconfig for simulators Message-ID: <20170912221535.GT2609@lianli.shorne-pla.net> References: <37f0d48de4690694c18be3d32483dafee0730859.1504129273.git.shorne@gmail.com> <20170911223712.GA31546@amd> <20170912074702.GA25921@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912074702.GA25921@amd> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 35 On Tue, Sep 12, 2017 at 09:47:02AM +0200, Pavel Machek wrote: > On Tue 2017-09-12 07:55:18, Stafford Horne wrote: > > On Tue, Sep 12, 2017 at 7:37 AM, Pavel Machek wrote: > > > On Thu 2017-08-31 07:03:11, Stafford Horne wrote: > > >> From: Stefan Kristiansson > > >> > > [...] > > >> +++ b/arch/openrisc/boot/dts/simple_smp.dts > > >> @@ -0,0 +1,58 @@ > > >> +/dts-v1/; > > >> +/ { > > >> + compatible = "opencores,or1ksim"; > > > > > > You may want to add some comment on top, explaining what this > > > is... and perhaps link to some page documenting how to set up > > > qemu/FPGAs? > > > > Sure, I can create an entry in Documentation/devicetree/binding > > documenting this since its been there for a while but was never properly > > documented. > > Yep, Documentation/devicetree should be mandatory. > > > But, just to be clear, what do you mean by page? Are you suggesting > > linking to a web page? Or do you mean something in Documentation/...? > > Whatever works for you. Maybe Documentation/ would be better... Actually, I forgot, we have something but its here: arch/openrisc/README.openrisc I'll work on some patches to move that to Documentation/ and clean it up. -Stafford