Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbdILWUc (ORCPT ); Tue, 12 Sep 2017 18:20:32 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:37327 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdILWU3 (ORCPT ); Tue, 12 Sep 2017 18:20:29 -0400 X-Google-Smtp-Source: AOwi7QBLb/MqBi9kYNptCJd+xpC1GNDxNJfK9hM5Y6IuENF8XX1CCyfm+07SaYM/z5QYUJiNY5dbMw== Date: Tue, 12 Sep 2017 17:20:27 -0500 From: Rob Herring To: Hans de Goede Cc: MyungJoo Ham , Chanwoo Choi , Guenter Roeck , Heikki Krogerus , Darren Hart , Andy Shevchenko , Peter Rosin , Mathias Nyman , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, Kuppuswamy Sathyanarayanan , Sathyanarayanan Kuppuswamy Natarajan , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support Message-ID: <20170912222027.hzpejmmxkwbw6seu@rob-hp-laptop> References: <20170905164221.11266-1-hdegoede@redhat.com> <20170905164221.11266-11-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905164221.11266-11-hdegoede@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 35 On Tue, Sep 05, 2017 at 06:42:20PM +0200, Hans de Goede wrote: > Add mux support to the fusb302 driver, call devm_tcpc_gen_mux_create() > to let the generic tcpc_mux_dev code create a tcpc_mux_dev for us. > > Also document the mux-names used by the generic tcpc_mux_dev code in > our devicetree bindings. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicetree@vger.kernel.org > Signed-off-by: Hans de Goede > --- > Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 3 +++ > drivers/staging/typec/fusb302/fusb302.c | 11 ++++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > index 472facfa5a71..63d639eadacd 100644 > --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > @@ -6,6 +6,9 @@ Required properties : > - interrupts : Interrupt specifier > > Optional properties : > +- mux-controls : List of mux-ctrl-specifiers containing 1 or 2 muxes > +- mux-names : "type-c-mode-mux" when using 1 mux, or > + "type-c-mode-mux", "usb-role-mux" when using 2 muxes I'm not sure this is the right place for this. The mux is outside the FUSB302. In a type-C connector node or USB phy node would make more sense to me. > - fcs,max-sink-microvolt : Maximum voltage to negotiate when configured as sink > - fcs,max-sink-microamp : Maximum current to negotiate when configured as sink > - fcs,max-sink-microwatt : Maximum power to negotiate when configured as sink