Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdILXlz (ORCPT ); Tue, 12 Sep 2017 19:41:55 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56673 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbdILXlw (ORCPT ); Tue, 12 Sep 2017 19:41:52 -0400 X-Originating-IP: 74.125.82.44 X-Google-Smtp-Source: AOwi7QDRsKtdRSYQtCtVCscl7TD3vf1IRt7JzrKsOoKVw9HRYpNRKXrxopKVW3RBDIYx42TSWfGx2yLtVP9FOEUWO4A= MIME-Version: 1.0 In-Reply-To: <1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com> From: Pravin Shelar Date: Tue, 12 Sep 2017 16:41:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode To: Haishuang Yan Cc: "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Linux Kernel Network Developers , linux-kernel@vger.kernel.org, Pravin B Shelar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 14 On Tue, Sep 12, 2017 at 2:47 AM, Haishuang Yan wrote: > In collect_md mode, if the tun dev is down, it still can call > ip_tunnel_rcv to receive on packets, and the rx statistics increase > improperly. > > When the md tunnel is down, it's not neccessary to increase RX drops > for the tunnel device, packets would be recieved on fallback tunnel, > and the RX drops on fallback device will be increased as expected. > > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Cc: Pravin B Shelar > Signed-off-by: Haishuang Yan Acked-by: Pravin B Shelar